Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-04 Thread Alex L via cfe-commits
On 4 May 2017 at 12:52, Alex L wrote: > > > On 4 May 2017 at 12:43, Alex L wrote: > >> >> >> On 3 May 2017 at 22:23, Richard Smith wrote: >> >>> On 3 May 2017 at 07:29, Alex L wrote: >>> Hi Richard, This commit has caused an infinite loop in one of our internal libclang bas

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-04 Thread Alex L via cfe-commits
On 4 May 2017 at 12:43, Alex L wrote: > > > On 3 May 2017 at 22:23, Richard Smith wrote: > >> On 3 May 2017 at 07:29, Alex L wrote: >> >>> Hi Richard, >>> >>> This commit has caused an infinite loop in one of our internal libclang >>> based tooling tests. It keeps repeating the following frames

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-04 Thread Alex L via cfe-commits
On 3 May 2017 at 22:23, Richard Smith wrote: > On 3 May 2017 at 07:29, Alex L wrote: > >> Hi Richard, >> >> This commit has caused an infinite loop in one of our internal libclang >> based tooling tests. It keeps repeating the following frames: >> >> frame #33528: 0x000109db2edf libclang

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-03 Thread Richard Smith via cfe-commits
On 3 May 2017 at 07:29, Alex L wrote: > Hi Richard, > > This commit has caused an infinite loop in one of our internal libclang > based tooling tests. It keeps repeating the following frames: > > frame #33528: 0x000109db2edf libclang.dylib`clang:: > DiagnosticsEngine::ReportDelayed(this=0

Re: r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-03 Thread Alex L via cfe-commits
Hi Richard, This commit has caused an infinite loop in one of our internal libclang based tooling tests. It keeps repeating the following frames: frame #33528: 0x000109db2edf libclang.dylib`clang::DiagnosticsEngine::ReportDelayed(this=0x00011c002c00) at Diagnostic.cpp:149 frame #3

r301992 - [modules] Round-trip -Werror flag through explicit module build.

2017-05-02 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue May 2 19:28:49 2017 New Revision: 301992 URL: http://llvm.org/viewvc/llvm-project?rev=301992&view=rev Log: [modules] Round-trip -Werror flag through explicit module build. The intent for an explicit module build is that the diagnostics produced within the module are thos