Re: r300295 - [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin

2017-04-14 Thread Vedant Kumar via cfe-commits
I hacked the UBSan runtime locally to use the fast unwinder. I thought this "worked", but it seems to only print one frame. This explains why: 67 void BufferedStackTrace::FastUnwindStack(uptr pc, uptr bp, uptr stack_top,

Re: r300295 - [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin

2017-04-14 Thread Kuba Mracek via cfe-commits
What exactly is wrong with the fast unwinder? It's used in ASan and TSan and besides not knowing about inlined frames, it works great. But we're almost always dealing with code that has frame pointers (and the sanitizer runtimes themselves are built with frame pointers). Kuba > On 13 Apr 201

Re: r300295 - [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin

2017-04-13 Thread Vedant Kumar via cfe-commits
Does anyone know what it would take to get the slow unwinder to work on Darwin? thanks, vedant > On Apr 13, 2017, at 6:59 PM, Vedant Kumar via cfe-commits > wrote: > > Author: vedantk > Date: Thu Apr 13 20:59:44 2017 > New Revision: 300295 > > URL: http://llvm.org/viewvc/llvm-project?rev=3002

r300295 - [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin

2017-04-13 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Thu Apr 13 20:59:44 2017 New Revision: 300295 URL: http://llvm.org/viewvc/llvm-project?rev=300295&view=rev Log: [docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin Printing out stack traces along with UBSan diagnostics is unsupported on Darwin. That's beca