Re: r299921 - [lsan] Enable LSan on arm Linux, clang part

2017-06-05 Thread Galina Kistanova via cfe-commits
The tests from https://reviews.llvm.org/rL299921 are not obviously enough. Those tests test only positive cases, thus do not catch when some flag is always true, like the bug we are discussing. There are missing tests that cover negative cases, when some sanitizer is not specified for a target. Th

Re: r299921 - [lsan] Enable LSan on arm Linux, clang part

2017-06-05 Thread Maxim Ostapenko via cfe-commits
On 05/06/17 21:06, David Blaikie wrote: On Mon, Jun 5, 2017 at 10:28 AM Maxim Ostapenko > wrote: On 05/06/17 20:16, David Blaikie wrote: > This change seemed to be buggy (& I assume missing test coverage to > demonstrate that). Galina fixed it in > h

Re: r299921 - [lsan] Enable LSan on arm Linux, clang part

2017-06-05 Thread David Blaikie via cfe-commits
On Mon, Jun 5, 2017 at 10:28 AM Maxim Ostapenko wrote: > On 05/06/17 20:16, David Blaikie wrote: > > This change seemed to be buggy (& I assume missing test coverage to > > demonstrate that). Galina fixed it in > > http://llvm.org/viewvc/llvm-project?rev=304663&view=rev based on a > > compiler wa

Re: r299921 - [lsan] Enable LSan on arm Linux, clang part

2017-06-05 Thread Maxim Ostapenko via cfe-commits
On 05/06/17 20:16, David Blaikie wrote: This change seemed to be buggy (& I assume missing test coverage to demonstrate that). Galina fixed it in http://llvm.org/viewvc/llvm-project?rev=304663&view=rev based on a compiler warning. Oh, right, I've missed that. Sorry! Can you add test covera

Re: r299921 - [lsan] Enable LSan on arm Linux, clang part

2017-06-05 Thread David Blaikie via cfe-commits
This change seemed to be buggy (& I assume missing test coverage to demonstrate that). Galina fixed it in http://llvm.org/viewvc/llvm-project?rev=304663&view=rev based on a compiler warning. Can you add test coverage to this code to exercise these untested codepaths? On Tue, Apr 11, 2017 at 12:34

r299921 - [lsan] Enable LSan on arm Linux, clang part

2017-04-11 Thread Maxim Ostapenko via cfe-commits
Author: chefmax Date: Tue Apr 11 02:22:11 2017 New Revision: 299921 URL: http://llvm.org/viewvc/llvm-project?rev=299921&view=rev Log: [lsan] Enable LSan on arm Linux, clang part This is a compiler part of https://reviews.llvm.org/D29586. Enable LSan on arm Linux. Differential Revision: https://