Re: r299226 - [Modules][PCH] Serialize #pragma pack

2017-04-18 Thread Alex L via cfe-commits
Thanks Duncan! On 15 April 2017 at 01:25, Duncan P. N. Exon Smith wrote: > FYI, I reverted the modules side of this in r300380. For details, see the > commit message. TL;DR: this didn't actually make modules builds closer to > matching non-modules builds, thanks to how submodules work; on the

Re: r299226 - [Modules][PCH] Serialize #pragma pack

2017-04-14 Thread Duncan P. N. Exon Smith via cfe-commits
FYI, I reverted the modules side of this in r300380. For details, see the commit message. TL;DR: this didn't actually make modules builds closer to matching non-modules builds, thanks to how submodules work; on the contrary, it made them diverge. > On 2017-Mar-31, at 08:36, Alex Lorenz via cf

r299226 - [Modules][PCH] Serialize #pragma pack

2017-03-31 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Mar 31 10:36:21 2017 New Revision: 299226 URL: http://llvm.org/viewvc/llvm-project?rev=299226&view=rev Log: [Modules][PCH] Serialize #pragma pack This patch serializes the state of #pragma pack. It preserves the state of the pragma from a PCH/from modules in a file that