Re: r298913 - Added `applyAtomicChanges` function.

2017-03-30 Thread Adrian Prantl via cfe-commits
Note that the green dragon bot doesn't use local submodule visibility, so every #include pulls in the entire clang module that header belongs to. Does this explain what you are seeing? (You should be able to reproduce with cmake -DLLVM_ENABLE_LOCAL_SUBMODULE_VISIBILITY=0) -- adrian > On Mar 30

Re: r298913 - Added `applyAtomicChanges` function.

2017-03-30 Thread Juergen Ributzka via cfe-commits
[+ Adrian] Adrian knows more about the bot setup. On Wed, Mar 29, 2017 at 8:04 AM, Eric Liu wrote: > Hi Juergen, thanks for taking care of this, but I'm wondering if this > build bot is using a different set of build rules? The error message says > "Clang_Tooling > -> Clang_Format -> Clang_Too

Re: r298913 - Added `applyAtomicChanges` function.

2017-03-29 Thread Eric Liu via cfe-commits
Hi Juergen, thanks for taking care of this, but I'm wondering if this build bot is using a different set of build rules? The error message says "Clang_Tooling -> Clang_Format -> Clang_Tooling"; however, the actual dependency is clangToolingRefactor -> clangFormat -> clangToolingCore, which seems fi

Re: r298913 - Added `applyAtomicChanges` function.

2017-03-28 Thread Juergen Ributzka via cfe-commits
I reverted the commit in r298967. Please fix the cyclic dependency issue found here: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-modulesRDA_build/4776/ Cheers, Juergen On Tue, Mar 28, 2017 at 6:05 AM, Eric Liu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ioeric > Date

r298913 - Added `applyAtomicChanges` function.

2017-03-28 Thread Eric Liu via cfe-commits
Author: ioeric Date: Tue Mar 28 08:05:32 2017 New Revision: 298913 URL: http://llvm.org/viewvc/llvm-project?rev=298913&view=rev Log: Added `applyAtomicChanges` function. Summary: ... which applies a set of `AtomicChange`s on code. Reviewers: klimek, djasper Reviewed By: djasper Subscribers: cf