Re: r296453 - [clang-format] Fix test failure caused by "rm" on some buildbots.

2017-02-28 Thread Haojian Wu via cfe-commits
Oops, I should have read the patch more thoroughly, sorry for it. Thanks for the explanation. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r296453 - [clang-format] Fix test failure caused by "rm" on some buildbots.

2017-02-28 Thread Nico Weber via cfe-commits
It's needed: when clang-format does leave temp files behind, they will accumulate over builds and even if that's then fixed, the test would still fail because of the temp files from prior builds. Thankfully, takuni fixed this better in r296460. On Feb 28, 2017 4:14 AM, "Haojian Wu via cfe-commits"

r296453 - [clang-format] Fix test failure caused by "rm" on some buildbots.

2017-02-28 Thread Haojian Wu via cfe-commits
Author: hokein Date: Tue Feb 28 03:03:07 2017 New Revision: 296453 URL: http://llvm.org/viewvc/llvm-project?rev=296453&view=rev Log: [clang-format] Fix test failure caused by "rm" on some buildbots. The begining command "rm" will return 1 when there is not such file to delete. This patch is to r