Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Dmitry Vyukov via cfe-commits
Ivan, you are listed as admin of http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf Please issue a clobber for it. If it does not help, the bot runs the following script: https://github.com/llvm-mirror/zorg/blob/master/zorg/buildbot/builders/sanitizers/buildbot_standard.sh It builds

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Vedant Kumar via cfe-commits
Hm, still can't reproduce this with a normal stage2-RA build of clang+compiler_rt. And it looks like the next build on the job has the same issue: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/5468/steps/annotate/logs/stdio Do you think there could be stale build p

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Dmitry Vyukov via cfe-commits
Does not seem to be related to tsan. It's just that somebody called a directory with compiler tsan_release_build, but that seems to be the only relation to tsan. Otherwise looks like a violated assertion in clang. On Mon, Feb 27, 2017 at 9:46 PM, Ivan Krasin wrote: > Hi Vedant, > > not on top of

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Ivan Krasin via cfe-commits
Hi Vedant, not on top of my head. Dmitriy, can you please take a look? krasin On Mon, Feb 27, 2017 at 12:43 PM, Vedant Kumar wrote: > Hi Ivan, > > I saw a bot failure on your job after this commit: > > http://lab.llvm.org:8011/builders/sanitizer-x86_64- > linux-autoconf/builds/5467/steps/tsa

Re: r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Vedant Kumar via cfe-commits
Hi Ivan, I saw a bot failure on your job after this commit: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/5467/steps/tsan%20analyze/logs/stdio http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoconf/builds/5467/steps/build%20release%20tsan%20with%20clang

r296374 - [ubsan] Factor out logic to emit a range check. NFC.

2017-02-27 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Mon Feb 27 13:46:19 2017 New Revision: 296374 URL: http://llvm.org/viewvc/llvm-project?rev=296374&view=rev Log: [ubsan] Factor out logic to emit a range check. NFC. This is a readability improvement, but it will also help prep an upcoming patch to detect UB loads from bitfie