Re: r293123 - Remove and replace DiagStatePoint tracking and lookup data structure.

2017-01-28 Thread Richard Smith via cfe-commits
On 28 Jan 2017 8:16 pm, "Duncan P. N. Exon Smith via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Hi Richard, This commit makes one of the tests fail in: https://reviews.llvm.org/D27689 The implicit modules model expects to be able to "upgrade" an implicit PCM with more -Werror flags *witho

Re: r293123 - Remove and replace DiagStatePoint tracking and lookup data structure.

2017-01-28 Thread Duncan P. N. Exon Smith via cfe-commits
Hi Richard, This commit makes one of the tests fail in: https://reviews.llvm.org/D27689 The implicit modules model expects to be able to "upgrade" an implicit PCM with more -Werror flags *without* affecting the signature. However, with your commit, the command-line diagnostic flags (e.g., -Wco

r293123 - Remove and replace DiagStatePoint tracking and lookup data structure.

2017-01-25 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Jan 25 19:01:01 2017 New Revision: 293123 URL: http://llvm.org/viewvc/llvm-project?rev=293123&view=rev Log: Remove and replace DiagStatePoint tracking and lookup data structure. Rather than storing a single flat list of SourceLocations where the diagnostic state changes (