Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-24 Thread Hans Wennborg via cfe-commits
Thanks for letting me know! I've merged your revert to the branch in r292947. Please let me know if there is any more follow-up. On Mon, Jan 23, 2017 at 6:30 PM, Devin Coughlin wrote: > FYI, I reverted r292800 from trunk in r292874. It was causing our internal > validation bots to have false pos

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Devin Coughlin via cfe-commits
FYI, I reverted r292800 from trunk in r292874. It was causing our internal validation bots to have false positives whenever a static local was dereferenced/passed to a nonnull function in a block evaluated at the top level. Devin > On Jan 23, 2017, at 4:19 PM, Hans Wennborg wrote: > > Merged

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Hans Wennborg via cfe-commits
Merged in r292858. Thanks, Hans On Mon, Jan 23, 2017 at 4:15 PM, Anna Zaks wrote: > Yes, ok to merge! > Thank you. > > Sent from my iPhone > >> On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote: >> >> Sounds good to me. >> >> Anna, you're the code owner here. Ok to merge this? >> >> Thanks, >> H

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Anna Zaks via cfe-commits
Yes, ok to merge! Thank you. Sent from my iPhone > On Jan 23, 2017, at 1:50 PM, Hans Wennborg wrote: > > Sounds good to me. > > Anna, you're the code owner here. Ok to merge this? > > Thanks, > Hans > >> On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev >> wrote: >> Hans, >> >> Could we m

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Hans Wennborg via cfe-commits
Sounds good to me. Anna, you're the code owner here. Ok to merge this? Thanks, Hans On Mon, Jan 23, 2017 at 10:37 AM, Artem Dergachev wrote: > Hans, > > Could we merge this one into the 4.0.0 release branch? It's a recent bugfix > for the analyzer. > > Thanks, > Artem. > > > > On 1/23/17 7:57 P

Re: r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Artem Dergachev via cfe-commits
Hans, Could we merge this one into the 4.0.0 release branch? It's a recent bugfix for the analyzer. Thanks, Artem. On 1/23/17 7:57 PM, Artem Dergachev via cfe-commits wrote: Author: dergachev Date: Mon Jan 23 10:57:11 2017 New Revision: 292800 URL: http://llvm.org/viewvc/llvm-project?rev=2

r292800 - [analyzer] Fix memory space of static locals seen from nested blocks.

2017-01-23 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Mon Jan 23 10:57:11 2017 New Revision: 292800 URL: http://llvm.org/viewvc/llvm-project?rev=292800&view=rev Log: [analyzer] Fix memory space of static locals seen from nested blocks. When a block within a function accesses a function's static local variable, this local is c