Re: r291058 - [Sema] Mark undefined ctors as deleted. NFC.

2017-01-09 Thread George Burgess IV via cfe-commits
That's a good point, but I don't think they're a big issue: this code has apparently been this way since 2010, and I only hit this problem because I was blindly adding `const` to things and looking for what broke. :) If someone feels differently, I'm happy to swap this to use SFINAE magic. On Mon

Re: r291058 - [Sema] Mark undefined ctors as deleted. NFC.

2017-01-09 Thread David Blaikie via cfe-commits
Alternatively could make the bool ctor a template with some SFINAE to restrict it to only parameters of type bool - thus blocking all conversions there, if they're particularly problematic. On Wed, Jan 4, 2017 at 5:32 PM George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Aut

r291058 - [Sema] Mark undefined ctors as deleted. NFC.

2017-01-04 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Wed Jan 4 19:21:21 2017 New Revision: 291058 URL: http://llvm.org/viewvc/llvm-project?rev=291058&view=rev Log: [Sema] Mark undefined ctors as deleted. NFC. Looks like these functions exist just to prevent bad implicit conversions. Rather than waiting for the linker to complain