Re: r290181 - [OPENMP] Fix for PR31416: Clang crashes on OMPCapturedExpr during source

2016-12-20 Thread Vedant Kumar via cfe-commits
Thank you for looking into this :)! I noticed that your test case doesn't hit the code coverage path, however. Perhaps it would be better to remove the PROF-INSTR-PATH check and instead introduce something like `test/CoverageMapping/openmp.cpp`: // RUN: %clang_cc1 -fopenmp -x c++ -triple x86_6

r290181 - [OPENMP] Fix for PR31416: Clang crashes on OMPCapturedExpr during source

2016-12-20 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 20 10:51:02 2016 New Revision: 290181 URL: http://llvm.org/viewvc/llvm-project?rev=290181&view=rev Log: [OPENMP] Fix for PR31416: Clang crashes on OMPCapturedExpr during source based coverage compilation Added source location info to captured expression declaration +