Re: r289308 - [clang-format] Another attempt at python 3 compatibility

2016-12-12 Thread Vedant Kumar via cfe-commits
Thanks for double-checking this. I realized that there's a problem with my patch: skipping the encoding step when using Python 3 could cause problems when we use difflib.SequenceMatcher. I don't know how to fix this, since the strings in vim.current.buffer appear to be 'raw'. They are not encoded

Re: r289308 - [clang-format] Another attempt at python 3 compatibility

2016-12-10 Thread Nico Weber via cfe-commits
Shouldn't this at least use >=? (But it feels like there is probably a way that doesn't have to do UA sniffing, so to speak) On Dec 9, 2016 8:04 PM, "Vedant Kumar via cfe-commits" < cfe-commits@lists.llvm.org> wrote: > Author: vedantk > Date: Fri Dec 9 18:54:13 2016 > New Revision: 289308 > > UR

r289308 - [clang-format] Another attempt at python 3 compatibility

2016-12-09 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Fri Dec 9 18:54:13 2016 New Revision: 289308 URL: http://llvm.org/viewvc/llvm-project?rev=289308&view=rev Log: [clang-format] Another attempt at python 3 compatibility The entries in vim.current.buffer appear to be decoded strings, which means that python3 won't allow invok