Re: r286096 - Deduplicate replacements by FileEntry instead of file names.

2016-11-07 Thread Kostya Serebryany via cfe-commits
Thanks! On Mon, Nov 7, 2016 at 10:53 AM, Eric Liu wrote: > r286132 should fix this. > > On Mon, Nov 7, 2016 at 10:40 AM Eric Liu wrote: > > Thanks Kostya! I'll look into this now. > > On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany wrote: > > Hi Eric, > > the asan bootstrap bot shows a leak

Re: r286096 - Deduplicate replacements by FileEntry instead of file names.

2016-11-07 Thread Eric Liu via cfe-commits
r286132 should fix this. On Mon, Nov 7, 2016 at 10:40 AM Eric Liu wrote: Thanks Kostya! I'll look into this now. On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany wrote: Hi Eric, the asan bootstrap bot shows a leak in this newly added tests. Please fix or revert ASAP. http://lab.llvm.org:801

Re: r286096 - Deduplicate replacements by FileEntry instead of file names.

2016-11-07 Thread Eric Liu via cfe-commits
Thanks Kostya! I'll look into this now. On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany wrote: > Hi Eric, > > the asan bootstrap bot shows a leak in this newly added tests. Please fix > or revert ASAP. > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/136/steps/chec

Re: r286096 - Deduplicate replacements by FileEntry instead of file names.

2016-11-07 Thread Kostya Serebryany via cfe-commits
Hi Eric, the asan bootstrap bot shows a leak in this newly added tests. Please fix or revert ASAP. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/136/steps/check-clang%20asan/logs/stdio Direct leak of 720 byte(s) in 1 object(s) allocated from: #0 0x6ace50 in operato

r286096 - Deduplicate replacements by FileEntry instead of file names.

2016-11-06 Thread Eric Liu via cfe-commits
Author: ioeric Date: Mon Nov 7 00:08:23 2016 New Revision: 286096 URL: http://llvm.org/viewvc/llvm-project?rev=286096&view=rev Log: Deduplicate replacements by FileEntry instead of file names. Summary: The current version does not deduplicate equivalent file paths correctly. For example, a relat