will do. I'll initiate a review for the original change and a new one for
the suggestions.
The ExpectedFunctionGlobalVarMethodOrProperty diagnostic was essentially a
copy-and-paste from here:
def Alias : Attr {
let Spellings = [GCC<"alias">];
let Args = [StringArgument<"Aliasee">];
let Sub
On Tue, Nov 8, 2016 at 3:52 PM, Kostya Serebryany via cfe-commits
wrote:
>
>
> On Tue, Nov 8, 2016 at 11:27 AM, Douglas Katzman wrote:
>>
>> oh, sorry for missing this email.
>> I'll say "no" - I was hoping you'd audit it!
>
>
> We do indeed have this practice for post-commit audit, but only for
On Tue, Nov 8, 2016 at 11:27 AM, Douglas Katzman wrote:
> oh, sorry for missing this email.
> I'll say "no" - I was hoping you'd audit it!
>
We do indeed have this practice for post-commit audit, but only for the
authors or active maintainers of the piece of code in question.
I afraid I do not f
On Fri, Oct 14, 2016 at 3:55 PM, Douglas Katzman via cfe-commits
wrote:
> Author: dougk
> Date: Fri Oct 14 14:55:09 2016
> New Revision: 284272
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev
> Log:
> Implement no_sanitize_address for global vars
>
> Modified:
> cfe/trunk/incl
oh, sorry for missing this email.
I'll say "no" - I was hoping you'd audit it!
jyknight looked at it and gave me the suggestion to fail the attribute
parsing if, in the non-deprecated syntax, _any_ of the no_sanitize
modifiers are inapplicable to global vars.
On Tue, Oct 25, 2016 at 7:19 PM, Kost
ping
On Mon, Oct 17, 2016 at 5:57 PM, Kostya Serebryany wrote:
> Did you code-review this?
> (sorry if I missed it)
>
> On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: dougk
>> Date: Fri Oct 14 14:55:09 2016
>> New Revision: 2
Did you code-review this?
(sorry if I missed it)
On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dougk
> Date: Fri Oct 14 14:55:09 2016
> New Revision: 284272
>
> URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev
> Log:
>
Author: dougk
Date: Fri Oct 14 14:55:09 2016
New Revision: 284272
URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev
Log:
Implement no_sanitize_address for global vars
Modified:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/tr
