Author: epilk
Date: Tue Oct 25 14:05:50 2016
New Revision: 285098
URL: http://llvm.org/viewvc/llvm-project?rev=285098&view=rev
Log:
Reapply r284265: "[Sema] Refactor context checking for availability diagnostics"
The problem with the original commit was that some of Apple's
Yes. I filed rdar://problem/28812809 to report that
problem in the SDK. I also filed rdar://problem/28825862
to remind us to restore the more strict checking
after we release a version of the tvOS SDK with a fix.
Thanks, Erik!
> On Oct 18, 2016, at 9:46 AM, Erik Pilkington
> wrote:
>
>
>
On second thought, I think the header *is* ill-formed here. If we allowed this
behaviour, this would provide a way to circumvent an availability diagnostic.
For example, now the following compiles cleanly, where we really should emit a
diagnostic somewhere!
typedef int unavail_int __attribute_
Hi Bob,
I think the code in the header is fine here, so I reverted in r284486. Here’s a
reduced version:
typedef int unavail_int __attribute__((availability(tvos, unavailable)));
__attribute__((availability(tvos, unavailable)))
@interface A
extern unavail_int foo;
@end
The problem is that ‘foo’
Author: epilk
Date: Tue Oct 18 10:26:43 2016
New Revision: 284486
URL: http://llvm.org/viewvc/llvm-project?rev=284486&view=rev
Log:
Revert r284265 "[Sema] Refactor context checking for availability diagnostics"
This has a bug in it, pointed out by Bob Wilson!
Modified:
cfe
Hi Erik,
This change does not work with one of the headers from the AVFoundation
framework in tvOS 10.0. We can try to get a fix into the tvOS SDK, but it will
probably be a while before we could release an SDK with that change. In the
meantime, this is kind of disruptive. Can you find a way to
Author: epilk
Date: Fri Oct 14 14:08:01 2016
New Revision: 284265
URL: http://llvm.org/viewvc/llvm-project?rev=284265&view=rev
Log:
[Sema] Refactor context checking for availability diagnostics
This commit combines a couple of redundant functions that do availability
attribute context checking in