Re: r283827 - [Driver][Diagnostics] Make 'show option names' default for driver warnings

2016-10-11 Thread Bruno Cardoso Lopes via cfe-commits
Let's see how it goes: Committed r283913 On Tue, Oct 11, 2016 at 11:13 AM, Bruno Cardoso Lopes wrote: > On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin > wrote: >> On 11 October 2016 at 16:34, Bruno Cardoso Lopes >> wrote: >>> Thanks Renato! >> >> So, Daniel Jasper did a trick on r283853 (clang

Re: r283827 - [Driver][Diagnostics] Make 'show option names' default for driver warnings

2016-10-11 Thread Bruno Cardoso Lopes via cfe-commits
On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin wrote: > On 11 October 2016 at 16:34, Bruno Cardoso Lopes > wrote: >> Thanks Renato! > > So, Daniel Jasper did a trick on r283853 (clang || true) to make it > not fail when it returns on error. However, I wasn't able to make it > return anything but

Re: r283827 - [Driver][Diagnostics] Make 'show option names' default for driver warnings

2016-10-11 Thread Renato Golin via cfe-commits
On 11 October 2016 at 16:34, Bruno Cardoso Lopes wrote: > Thanks Renato! So, Daniel Jasper did a trick on r283853 (clang || true) to make it not fail when it returns on error. However, I wasn't able to make it return anything but 0, so I'm at odds why this fails on the bot. I was expecting it to

Re: r283827 - [Driver][Diagnostics] Make 'show option names' default for driver warnings

2016-10-11 Thread Bruno Cardoso Lopes via cfe-commits
Thanks Renato! On Tue, Oct 11, 2016 at 3:36 AM, Renato Golin wrote: > On 11 October 2016 at 10:14, Renato Golin wrote: >> clang-4.0: warning: no such sysroot directory: '/FOO' [-Wmissing-sysroot] >> error: unable to create target: 'No available targets are compatible >> with this triple.' >> 1 e

Re: r283827 - [Driver][Diagnostics] Make 'show option names' default for driver warnings

2016-10-11 Thread Renato Golin via cfe-commits
On 11 October 2016 at 10:14, Renato Golin wrote: > clang-4.0: warning: no such sysroot directory: '/FOO' [-Wmissing-sysroot] > error: unable to create target: 'No available targets are compatible > with this triple.' > 1 error generated. Reverted in r283868, as it was also breaking ARM bots. che

Re: r283827 - [Driver][Diagnostics] Make 'show option names' default for driver warnings

2016-10-11 Thread Renato Golin via cfe-commits
On 11 October 2016 at 01:01, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Mon Oct 10 19:01:22 2016 > New Revision: 283827 > > URL: http://llvm.org/viewvc/llvm-project?rev=283827&view=rev > Log: > [Driver][Diagnostics] Make 'show option names' default for driver warnings > > C

r283827 - [Driver][Diagnostics] Make 'show option names' default for driver warnings

2016-10-10 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Mon Oct 10 19:01:22 2016 New Revision: 283827 URL: http://llvm.org/viewvc/llvm-project?rev=283827&view=rev Log: [Driver][Diagnostics] Make 'show option names' default for driver warnings Currently, driver level warnings do not show option names (e.g. warning: complain about fo