Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-11 Thread Reid Kleckner via cfe-commits
On Tue, Oct 11, 2016 at 9:34 AM, Justin Lebar wrote: > > Can we figure out why having an incremental stage1 is problematic? I > want to keep it that way to speed up the bot. > > The problem is that the cmake install rule that we use does not remove > extra files that happen to be present in the i

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-11 Thread Justin Lebar via cfe-commits
> Can we figure out why having an incremental stage1 is problematic? I want to > keep it that way to speed up the bot. The problem is that the cmake install rule that we use does not remove extra files that happen to be present in the install directory. So if you put something bad in there, as I

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-11 Thread Reid Kleckner via cfe-commits
Can we figure out why having an incremental stage1 is problematic? I want to keep it that way to speed up the bot. It sounds like the problem is that we do not delete the stage1 install directory before installing to it, or our install step uses a glob that may include stale files from previous bu

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-10 Thread Hal Finkel via cfe-commits
- Original Message - > From: "Justin Lebar" > To: "Hal Finkel" > Cc: "Clang Commits" > Sent: Saturday, October 8, 2016 10:56:37 PM > Subject: Re: r283680 - [CUDA] Support and std::min/max on the > device. > > > > The f

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-10 Thread Justin Lebar via cfe-commits
As discussed over IM, builds are still failing after reverting this. The issue seems to be that the stage 1 build in bootstrap compiles is not a clean build. Therefore the errant and headers are never removed from the install directory. I believe I fixed the cmake in r283683 (sent a few hours

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-10 Thread Nico Weber via cfe-commits
This broke bootstrap builds, I reverted it for now in r283747. On Sat, Oct 8, 2016 at 6:16 PM, Justin Lebar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jlebar > Date: Sat Oct 8 17:16:12 2016 > New Revision: 283680 > > URL: http://llvm.org/viewvc/llvm-project?rev=283680&view=re

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-09 Thread Justin Lebar via cfe-commits
se with >>> -ffast-math >>> -ffinite-math-only. GCC can do it. Clang gets std::isnan. >>> https://godbolt.org/g/vZB55a >>> >>> By the way, the changes you made to libc++ unfortunately break this >>> patch with libc++, because e.g. __libcpp_isnan is no

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-08 Thread Justin Lebar via cfe-commits
gt; - Original Message - >> From: "Justin Lebar" >> To: "Hal Finkel" >> Cc: "Clang Commits" >> Sent: Saturday, October 8, 2016 6:16:12 PM >> Subject: Re: r283680 - [CUDA] Support and std::min/max on the >> device. >> >&g

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-08 Thread Hal Finkel via cfe-commits
- Original Message - > From: "Justin Lebar" > To: "Hal Finkel" > Cc: "Clang Commits" > Sent: Saturday, October 8, 2016 6:16:12 PM > Subject: Re: r283680 - [CUDA] Support and std::min/max on the > device. > > Hal, > > O

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-08 Thread Justin Lebar via cfe-commits
essage - >> From: "Justin Lebar via cfe-commits" >> To: cfe-commits@lists.llvm.org >> Sent: Saturday, October 8, 2016 5:16:13 PM >> Subject: r283680 - [CUDA] Support and std::min/max on the device. >> >> Author: jlebar >> Date: Sat Oct 8 17:16

Re: r283680 - [CUDA] Support and std::min/max on the device.

2016-10-08 Thread Hal Finkel via cfe-commits
ch is similar to what libstdc++ ends up doing, so that we use __builtin_isnan/isinf/isfinite. Thanks again, Hal - Original Message - > From: "Justin Lebar via cfe-commits" > To: cfe-commits@lists.llvm.org > Sent: Saturday, October 8, 2016 5:16:13 PM > Subject: r28368

r283680 - [CUDA] Support and std::min/max on the device.

2016-10-08 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Sat Oct 8 17:16:12 2016 New Revision: 283680 URL: http://llvm.org/viewvc/llvm-project?rev=283680&view=rev Log: [CUDA] Support and std::min/max on the device. Summary: We do this by wrapping and . Tests are in the test-suite. Reviewers: tra Subscribers: jhen, beanz, cfe-