This revision was automatically updated to reflect the committed changes.
Closed by commit rL281891: Recommit r281457 "Supports adding insertion around
non-insertion replacements". (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D24606?vs=71777&id=71779#t
Author: ioeric
Date: Mon Sep 19 03:40:42 2016
New Revision: 281891
URL: http://llvm.org/viewvc/llvm-project?rev=281891&view=rev
Log:
Recommit r281457 "Supports adding insertion around non-insertion replacements".
Summary:
Diff to r281457:
- add
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D24606
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ioeric added a comment.
This patch now only recommits https://reviews.llvm.org/D24515 with an
additional test case `CalculateRangesOfInsertionAroundReplacement`.
https://reviews.llvm.org/D24606
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ioeric updated this revision to Diff 71777.
ioeric added a comment.
- Supports adding insertion around non-insertion replacements. Recommit r281457.
- Also add a test case for calculating ranges for replacements with the same
offset.
https://reviews.llvm.org/D24606
Files:
include/clang/Tooli
ioeric updated this revision to Diff 71495.
ioeric added a comment.
- Update comment in `getAffectedRanges`.
https://reviews.llvm.org/D24606
Files:
include/clang/Tooling/Core/Replacement.h
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/Ref
Author: tra
Date: Wed Sep 14 18:03:06 2016
New Revision: 281557
URL: http://llvm.org/viewvc/llvm-project?rev=281557&view=rev
Log:
Revert r281457 "Supports adding insertion around non-insertion replacements."
Commit was breaking our internal tests.
Modified:
cfe/trunk/include
Author: ioeric
Date: Wed Sep 14 08:04:51 2016
New Revision: 281457
URL: http://llvm.org/viewvc/llvm-project?rev=281457&view=rev
Log:
Supports adding insertion around non-insertion replacements.
Summary:
Extend `tooling::Replacements::add()` to support adding order-independent
replacements.
Two
