Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-20 Thread Joerg Sonnenberger via cfe-commits
On Sat, Aug 20, 2016 at 12:45:59AM +, Chandler Carruth wrote: > I feel like this thread has two very unrelated concerns and it might be > useful to separate them. > > 1) Should an application be changing the stack limit, or should the system > be able to enforce this? > > Fortunately, there a

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Sean Silva via cfe-commits
On Fri, Aug 19, 2016 at 4:33 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 19, 2016 at 03:30:42PM -0700, Richard Smith wrote: > > It typically does; the default stack ulimit is likely tuned for "normal" > > applications that are not expected (by an ISO s

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Chandler Carruth via cfe-commits
I feel like this thread has two very unrelated concerns and it might be useful to separate them. 1) Should an application be changing the stack limit, or should the system be able to enforce this? Fortunately, there are two limits. One an application is allowed to change, one it isn't. It seems l

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Joerg Sonnenberger via cfe-commits
On Fri, Aug 19, 2016 at 03:30:42PM -0700, Richard Smith wrote: > It typically does; the default stack ulimit is likely tuned for "normal" > applications that are not expected (by an ISO standard) to cope with > recursing a thousand levels deep. If the system administrator really wants > to control

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Richard Smith via cfe-commits
On Fri, Aug 19, 2016 at 1:43 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 19, 2016 at 01:16:59PM -0700, Richard Smith wrote: > > On Fri, Aug 19, 2016 at 1:10 PM, Joerg Sonnenberger via cfe-commits < > > cfe-commits@lists.llvm.org> wrote: > > > > > On Fr

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Joerg Sonnenberger via cfe-commits
On Fri, Aug 19, 2016 at 01:16:59PM -0700, Richard Smith wrote: > On Fri, Aug 19, 2016 at 1:10 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Fri, Aug 19, 2016 at 01:03:51PM -0700, Richard Smith wrote: > > > On Fri, Aug 19, 2016 at 12:58 PM, Joerg Sonnenberge

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Richard Smith via cfe-commits
On Fri, Aug 19, 2016 at 1:10 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 19, 2016 at 01:03:51PM -0700, Richard Smith wrote: > > On Fri, Aug 19, 2016 at 12:58 PM, Joerg Sonnenberger via cfe-commits < > > cfe-commits@lists.llvm.org> wrote: > > > > > On T

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Joerg Sonnenberger via cfe-commits
On Fri, Aug 19, 2016 at 01:03:51PM -0700, Richard Smith wrote: > On Fri, Aug 19, 2016 at 12:58 PM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Thu, Aug 18, 2016 at 11:33:49AM -0700, Richard Smith wrote: > > > On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberge

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Richard Smith via cfe-commits
On Fri, Aug 19, 2016 at 12:58 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Aug 18, 2016 at 11:33:49AM -0700, Richard Smith wrote: > > On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberger via cfe-commits < > > cfe-commits@lists.llvm.org> wrote: > > > > > On W

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-19 Thread Joerg Sonnenberger via cfe-commits
On Thu, Aug 18, 2016 at 11:33:49AM -0700, Richard Smith wrote: > On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberger via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits > > wrote: > > > Author: rsmith > > > Date: Tue

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-18 Thread Richard Smith via cfe-commits
On Wed, Aug 17, 2016 at 6:35 AM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits > wrote: > > Author: rsmith > > Date: Tue Aug 16 20:05:07 2016 > > New Revision: 278882 > > > > URL: http://llvm.org/vi

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-18 Thread Richard Smith via cfe-commits
llvm-config.h doesn't provide the necessary macros. I've applied a different fix for out-of-tree builds in r279112. On Wed, Aug 17, 2016 at 11:51 PM, Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Done in clang/r279035. > > thanks, > vedant > > > On Aug 17, 2016, at 7:43 AM,

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-17 Thread Vedant Kumar via cfe-commits
Done in clang/r279035. thanks, vedant > On Aug 17, 2016, at 7:43 AM, Will Dietz via cfe-commits > wrote: > > (Seems to fix the build here, FWIW. If sounds reasonable can someone commit > this? Thanks!) > > ~Will > > On Wed, Aug 17, 2016 at 9:39 AM Will Dietz wrote: > This is the first use

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-17 Thread Will Dietz via cfe-commits
(Seems to fix the build here, FWIW. If sounds reasonable can someone commit this? Thanks!) ~Will On Wed, Aug 17, 2016 at 9:39 AM Will Dietz wrote: > This is the first use of "llvm/Config/config.h" in the clang tree, which > breaks out-of-tree builds for me (since llvm's config.h isn't installe

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-17 Thread Will Dietz via cfe-commits
This is the first use of "llvm/Config/config.h" in the clang tree, which breaks out-of-tree builds for me (since llvm's config.h isn't installed). Would using "llvm/Config/llvm-config.h" suffice instead? I'm trying that now... ~Will On Wed, Aug 17, 2016 at 8:36 AM Joerg Sonnenberger via cfe-comm

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-17 Thread Joerg Sonnenberger via cfe-commits
On Wed, Aug 17, 2016 at 01:05:08AM -, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue Aug 16 20:05:07 2016 > New Revision: 278882 > > URL: http://llvm.org/viewvc/llvm-project?rev=278882&view=rev > Log: > If possible, set the stack rlimit to at least 8MiB on cc1 startup, and w

r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

2016-08-16 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Aug 16 20:05:07 2016 New Revision: 278882 URL: http://llvm.org/viewvc/llvm-project?rev=278882&view=rev Log: If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work around a Linux kernel bug where the actual amount of available stack may be a *lot* lower