Re: r276907 - Add flags to toggle preservation of assembly comments

2016-07-27 Thread Renato Golin via cfe-commits
On 27 July 2016 at 21:57, Nirav Davé wrote: > Looks like I missed the target triple. Should work now. Still failing on *all* ARM targets. 'No available targets are compatible with this triple.' Please move the test to an x86 directory. http://llvm.org/docs/TestingGuide.html#platform-specific-t

Re: r276907 - Add flags to toggle preservation of assembly comments

2016-07-27 Thread Nirav Davé via cfe-commits
Looks like I missed the target triple. Should work now. Thanks, -Nirav On Wed, Jul 27, 2016 at 4:41 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Nirav, > > This test is failing on darwin: > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574 > >

Re: r276907 - Add flags to toggle preservation of assembly comments

2016-07-27 Thread Bruno Cardoso Lopes via cfe-commits
Hi Nirav, This test is failing on darwin: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574 Can you take a look? On Wed, Jul 27, 2016 at 12:57 PM, Nirav Dave via cfe-commits wrote: > Author: niravd > Date: Wed Jul 27 14:57:40 2016 > New Revision: 276907 > > URL: h

r276907 - Add flags to toggle preservation of assembly comments

2016-07-27 Thread Nirav Dave via cfe-commits
Author: niravd Date: Wed Jul 27 14:57:40 2016 New Revision: 276907 URL: http://llvm.org/viewvc/llvm-project?rev=276907&view=rev Log: Add flags to toggle preservation of assembly comments Summary: Add -fpreserve-as-comments and -fno-preserve-as-comments. Reviewers: echristo, rnk Subscribers: meh