Re: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-14 Thread David Blaikie via cfe-commits
> >> I think no DWARF-using target has dllimport (yet) so you are actually >> handling a new situation here. Being unable to find the entity in the >> dllimport-using CU is not a friendly debugging experience. >> >> --paulr >> >> >> >> *

Re: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-12 Thread David Majnemer via cfe-commits
tity the same way we currently treat > declarations: ignore them. > > I don't have the bandwidth to generically improve debug info beyond what > we can do for DWARF/GDB targets. > > > > --paulr > > > > *From:* David Majnemer [mailto:david.majne...@gmail.com

RE: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-12 Thread Robinson, Paul via cfe-commits
From: David Majnemer [mailto:david.majne...@gmail.com] Sent: Tuesday, July 12, 2016 2:07 PM To: Robinson, Paul Cc: cfe-commits (cfe-commits@lists.llvm.org) Subject: Re: r275040 - [CodeGen] Treat imported static local variables as declarations On Tue, Jul 12, 2016 at 2:02 PM, Robinson, Paul

Re: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-12 Thread David Majnemer via cfe-commits
:* Monday, July 11, 2016 12:27 PM > > *To:* Robinson, Paul > *Cc:* cfe-commits (cfe-commits@lists.llvm.org) > *Subject:* Re: r275040 - [CodeGen] Treat imported static local variables > as declarations > > > > > > > > On Mon, Jul 11, 2016 at 11:45 AM, Robinson, Paul &

RE: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-12 Thread Robinson, Paul via cfe-commits
To: Robinson, Paul Cc: cfe-commits (cfe-commits@lists.llvm.org) Subject: Re: r275040 - [CodeGen] Treat imported static local variables as declarations On Mon, Jul 11, 2016 at 11:45 AM, Robinson, Paul mailto:paul.robin...@sony.com>> wrote: It was not particularly obvious that by "s

Re: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-11 Thread David Majnemer via cfe-commits
day, July 11, 2016 9:53 AM > *To:* Robinson, Paul > *Cc:* cfe-commits (cfe-commits@lists.llvm.org) > *Subject:* Re: r275040 - [CodeGen] Treat imported static local variables > as declarations > > > > > > > > On Mon, Jul 11, 2016 at 9:48 AM, Robinson, Paul > wrote: &

RE: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-11 Thread Robinson, Paul via cfe-commits
ent: Monday, July 11, 2016 9:53 AM To: Robinson, Paul Cc: cfe-commits (cfe-commits@lists.llvm.org) Subject: Re: r275040 - [CodeGen] Treat imported static local variables as declarations On Mon, Jul 11, 2016 at 9:48 AM, Robinson, Paul mailto:paul.robin...@sony.com>> wrote: This changes the

Re: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-11 Thread David Majnemer via cfe-commits
[mailto:cfe-commits-boun...@lists.llvm.org] On Behalf > Of > > David Majnemer via cfe-commits > > Sent: Sunday, July 10, 2016 9:28 PM > > To: cfe-commits@lists.llvm.org > > Subject: r275040 - [CodeGen] Treat imported static local variables as > > declarations > >

RE: r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-11 Thread Robinson, Paul via cfe-commits
; Subject: r275040 - [CodeGen] Treat imported static local variables as > declarations > > Author: majnemer > Date: Sun Jul 10 23:28:21 2016 > New Revision: 275040 > > URL: http://llvm.org/viewvc/llvm-project?rev=275040&view=rev > Log: > [CodeGen] Treat imported sta

r275040 - [CodeGen] Treat imported static local variables as declarations

2016-07-10 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sun Jul 10 23:28:21 2016 New Revision: 275040 URL: http://llvm.org/viewvc/llvm-project?rev=275040&view=rev Log: [CodeGen] Treat imported static local variables as declarations Imported variables cannot really be definitions for the purposes of IR generation. Modified: