Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-07-11 Thread David Blaikie via cfe-commits
On Mon, Jul 11, 2016 at 1:05 PM, Reid Kleckner wrote: > On Mon, Jul 11, 2016 at 10:35 AM, David Blaikie > wrote: >> >> I believe so, but don't have specific numbers. Alexey made this choice >> when it was originally implemented & I believe had the data back then. >> > > I don't think we made an

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-07-11 Thread Reid Kleckner via cfe-commits
On Mon, Jul 11, 2016 at 10:35 AM, David Blaikie wrote: > > I believe so, but don't have specific numbers. Alexey made this choice > when it was originally implemented & I believe had the data back then. > I don't think we made an explicit choice to use short names. gdb and addr2line just give you

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-07-11 Thread David Blaikie via cfe-commits
On Fri, Jul 8, 2016 at 1:04 PM, Nico Weber wrote: > On Fri, Jul 8, 2016 at 3:57 PM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> >> On Thu, Jul 7, 2016 at 4:10 PM, Reid Kleckner wrote: >> >>> On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie >>> wrote: >>> Yeah

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-07-08 Thread Nico Weber via cfe-commits
On Fri, Jul 8, 2016 at 3:57 PM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Thu, Jul 7, 2016 at 4:10 PM, Reid Kleckner wrote: > >> On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie wrote: >> >>> Yeah - is this necessary for CodeView? (does something break, or do you >

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-07-08 Thread David Blaikie via cfe-commits
On Thu, Jul 7, 2016 at 4:10 PM, Reid Kleckner wrote: > On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie wrote: > >> Yeah - is this necessary for CodeView? (does something break, or do you >> just get simple names where you'd prefer full mangled or qualified names) >> >> It was chosen pretty deliber

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-07-07 Thread Reid Kleckner via cfe-commits
On Thu, Jul 7, 2016 at 3:45 PM, David Blaikie wrote: > Yeah - is this necessary for CodeView? (does something break, or do you > just get simple names where you'd prefer full mangled or qualified names) > > It was chosen pretty deliberately to do it this way (use unqualified > names) for gmlt to

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-07-07 Thread David Blaikie via cfe-commits
Yeah - is this necessary for CodeView? (does something break, or do you just get simple names where you'd prefer full mangled or qualified names) It was chosen pretty deliberately to do it this way (use unqualified names) for gmlt to keep size down. Have you got numbers for the size delta for Code

RE: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-06-30 Thread Robinson, Paul via cfe-commits
Reid Kleckner via cfe-commits Sent: Thursday, June 30, 2016 11:06 AM To: cfe-commits; David Blaikie; Robinson, Paul Subject: Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on David and Paul, Do you think I should enable this behavior for DWARF as well? We on

Re: r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-06-30 Thread Reid Kleckner via cfe-commits
David and Paul, Do you think I should enable this behavior for DWARF as well? We only emit a DW_TAG_subprogram when a function is inlined or contains inlined functions, which might not be that many. IIRC Paul did something similar with DW_AT_linkage_name, and the object file size cost wasn't that

r274246 - [codeview] Emit qualified display names if -gline-tables-only is on

2016-06-30 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Jun 30 12:41:31 2016 New Revision: 274246 URL: http://llvm.org/viewvc/llvm-project?rev=274246&view=rev Log: [codeview] Emit qualified display names if -gline-tables-only is on When -gmlt is on, we don't emit namespace or class scope information, and the CodeView emission cod