lgtm
On Sun, Jun 5, 2016 at 3:31 PM, Rafael Espíndola wrote:
> Patch attached. What do you think?
>
> Cheers,
> Rafael
>
>
> On 3 June 2016 at 16:11, Ed Maste wrote:
> > On 3 June 2016 at 15:53, Nico Weber via cfe-commits
> > wrote:
> >> Can you add this to the release notes? It'll for example
Patch attached. What do you think?
Cheers,
Rafael
On 3 June 2016 at 16:11, Ed Maste wrote:
> On 3 June 2016 at 15:53, Nico Weber via cfe-commits
> wrote:
>> Can you add this to the release notes? It'll for example break chromium's
>> crash server (we can fix this on our end by explicitly passi
On 3 June 2016 at 15:53, Nico Weber via cfe-commits
wrote:
> Can you add this to the release notes? It'll for example break chromium's
> crash server (we can fix this on our end by explicitly passing
> -Wl,--build-id for release builds, but we only saw this commit fly by by
> chance.)
Good point.
Can you add this to the release notes? It'll for example break chromium's
crash server (we can fix this on our end by explicitly passing
-Wl,--build-id for release builds, but we only saw this commit fly by by
chance.)
On Fri, Jun 3, 2016 at 1:26 PM, Rafael Espindola via cfe-commits <
cfe-commits@
Author: rafael
Date: Fri Jun 3 12:26:16 2016
New Revision: 271692
URL: http://llvm.org/viewvc/llvm-project?rev=271692&view=rev
Log:
Don't pass --build-id to ld by default.
We now have a cmake option to change the default: ENABLE_LINKER_BUILD_ID.
The reason is that build-id is fairly expensive,
