RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-06-08 Thread Anastasia Stulova via cfe-commits
et. But these particularly don't seem to have any use in the compiler indeed. -Original Message- From: Jeroen Ketema [mailto:j.ket...@imperial.ac.uk] Sent: 06 June 2016 22:16 To: Liu, Yaxun (Sam) Cc: Anastasia Stulova; Clang Commits; nd Subject: Re: r269670 - [OpenCL] Add supported OpenCL

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-06-07 Thread Liu, Yaxun (Sam) via cfe-commits
you OK with that? Thanks. Sam -Original Message- From: Jeroen Ketema [mailto:j.ket...@imperial.ac.uk] Sent: Monday, June 6, 2016 5:16 PM To: Liu, Yaxun (Sam) Cc: Anastasia Stulova ; Clang Commits ; nd Subject: Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info. Hi Sam

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-06-06 Thread Jeroen Ketema via cfe-commits
r an extension is enabled is reprented by Actions.getOpenCLOptions(), > which changes with pragma. > > test/SemaOpenCL/extensions.cl contains examples of unsupported extensions. > > Sam > > -Original Message----- > From: Jeroen Ketema [mailto:j.ket...@imperial.ac.u

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-06-03 Thread Anastasia Stulova via cfe-commits
Anastasia -Original Message- From: Jeroen Ketema [mailto:j.ket...@imperial.ac.uk] Sent: 31 May 2016 23:07 To: Liu, Yaxun (Sam) Cc: Anastasia Stulova; Clang Commits; nd Subject: Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info. Hi Sam, > This commit does not change the ini

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-06-02 Thread Liu, Yaxun (Sam) via cfe-commits
Original Message- From: Jeroen Ketema [mailto:j.ket...@imperial.ac.uk] Sent: Tuesday, May 31, 2016 6:07 PM To: Liu, Yaxun (Sam) Cc: Anastasia Stulova ; Clang Commits ; nd Subject: Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info. Hi Sam, > This commit does not change t

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-31 Thread Jeroen Ketema via cfe-commits
Hi Sam, > This commit does not change the initial state of the extensions. An extension > is supported is not the same as enabled. At the beginning all extensions are > disabled. I do not see this reflected in the code at all. Could you please: a. Point me to the location where this distinctio

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-31 Thread Liu, Yaxun (Sam) via cfe-commits
- From: Jeroen Ketema [mailto:j.ket...@imperial.ac.uk] Sent: Tuesday, May 31, 2016 5:36 PM To: Liu, Yaxun (Sam) Cc: Anastasia Stulova ; Clang Commits ; nd Subject: Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info. By the way, are you accidentally violating: The

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-31 Thread Jeroen Ketema via cfe-commits
sabled then use it to condition your code. >> >> Thanks. >> >> Sam >> >> -----Original Message----- >> From: Jeroen Ketema [mailto:j.ket...@imperial.ac.uk] >> Sent: Monday, May 30, 2016 10:08 AM >> To: Anastasia Stulova >> Cc: Liu, Yax

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-31 Thread Jeroen Ketema via cfe-commits
use it to condition your code. > > Thanks. > > Sam > > -Original Message- > From: Jeroen Ketema [mailto:j.ket...@imperial.ac.uk] > Sent: Monday, May 30, 2016 10:08 AM > To: Anastasia Stulova > Cc: Liu, Yaxun (Sam) ; Clang Commits > ; nd > Subje

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-31 Thread Liu, Yaxun (Sam) via cfe-commits
gt; -Original Message- > From: Liu, Yaxun (Sam) [mailto:yaxun@amd.com] > Sent: 20 May 2016 20:52 > To: Anastasia Stulova; Jeroen Ketema > Cc: Clang Commits; nd > Subject: RE: r269670 - [OpenCL] Add supported OpenCL extensions to target > info. > > I think this fea

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-30 Thread Jeroen Ketema via cfe-commits
le type > is used by user's program. > > Sam > > -Original Message- > From: Liu, Yaxun (Sam) > Sent: Friday, May 20, 2016 3:45 PM > To: 'Anastasia Stulova' ; Jeroen Ketema > > Cc: Clang Commits ; nd > Subject: RE: r269670 - [OpenCL] Add supp

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-20 Thread Anastasia Stulova via cfe-commits
Yaxun (Sam) Sent: Friday, May 20, 2016 3:45 PM To: 'Anastasia Stulova' ; Jeroen Ketema Cc: Clang Commits ; nd Subject: RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info. Currently Clang does not emit opencl.used.extensions metadata, so the issue mentioned d

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-20 Thread Liu, Yaxun (Sam) via cfe-commits
y 20, 2016 3:45 PM To: 'Anastasia Stulova' ; Jeroen Ketema Cc: Clang Commits ; nd Subject: RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info. Currently Clang does not emit opencl.used.extensions metadata, so the issue mentioned does not exist. Also extensions s

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-20 Thread Liu, Yaxun (Sam) via cfe-commits
adata. Sam -Original Message- From: Anastasia Stulova [mailto:anastasia.stul...@arm.com] Sent: Friday, May 20, 2016 3:23 PM To: Liu, Yaxun (Sam) ; Jeroen Ketema Cc: Clang Commits ; nd Subject: Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info. Hi Sam, Has this

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-20 Thread Anastasia Stulova via cfe-commits
have any other proposal for the solution? Thanks, Anastasia From: cfe-commits on behalf of Jeroen Ketema via cfe-commits Sent: 17 May 2016 12:49 To: Yaxun Liu via cfe-commits Subject: Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-17 Thread Jeroen Ketema via cfe-commits
Hi, The below commit enables all OpenCL extensions for the SPIR target by default. This incorrect, as SPIR allows you to specify which extensions are enabled/disabled its metadata. This means that any SPIR generated by Clang may now be rejected by specific OpenCL platforms, because they might

r269670 - [OpenCL] Add supported OpenCL extensions to target info.

2016-05-16 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Mon May 16 12:06:34 2016 New Revision: 269670 URL: http://llvm.org/viewvc/llvm-project?rev=269670&view=rev Log: [OpenCL] Add supported OpenCL extensions to target info. Add supported OpenCL extensions to target info. It serves as default values to save the users of the burde