Re: r264008 - [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

2016-06-30 Thread Justin Lebar via cfe-commits
I think this code is accidentally OK, because the list of overloads that callers pass in in should have at most two elements. A given overload set may have both a __host__ and a __device__ function, or alternatively it may have a __host__ __device__ function, but you can't have all three. There i

Re: r264008 - [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

2016-06-30 Thread Justin Lebar via cfe-commits
Interestingly all the clang tests pass with that whole line commented out. So something *really* seems missing here. Thank you for finding this. On Thu, Jun 30, 2016 at 5:08 AM, Benjamin Kramer wrote: > On Tue, Mar 22, 2016 at 1:09 AM, Justin Lebar via cfe-commits > wrote: >> Author: jlebar >>

Re: r264008 - [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

2016-06-30 Thread Benjamin Kramer via cfe-commits
On Tue, Mar 22, 2016 at 1:09 AM, Justin Lebar via cfe-commits wrote: > Author: jlebar > Date: Mon Mar 21 19:09:25 2016 > New Revision: 264008 > > URL: http://llvm.org/viewvc/llvm-project?rev=264008&view=rev > Log: > [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl. > > Summary: NFC

r264008 - [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl.

2016-03-21 Thread Justin Lebar via cfe-commits
Author: jlebar Date: Mon Mar 21 19:09:25 2016 New Revision: 264008 URL: http://llvm.org/viewvc/llvm-project?rev=264008&view=rev Log: [sema] [CUDA] Use std algorithms in EraseUnwantedCUDAMatchesImpl. Summary: NFC Reviewers: tra Subscribers: cfe-commits Differential Revision: http://reviews.llvm