Re: r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

2016-03-24 Thread Stephan Bergmann via cfe-commits
On 03/22/2016 06:38 PM, Reid Kleckner wrote: Ugh, templates and friend function definitions strike again! I think this is where "semantic" vs. "lexical" DeclContexts come into play. Try doing D->getLexicalDeclContext()->isDependentContext(). Great, thanks, that's what I'd been searching for.

Re: r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

2016-03-22 Thread Reid Kleckner via cfe-commits
Ugh, templates and friend function definitions strike again! I think this is where "semantic" vs. "lexical" DeclContexts come into play. Try doing D->getLexicalDeclContext()->isDependentContext(). On Tue, Mar 22, 2016 at 5:23 AM, Stephan Bergmann wrote: > On 03/17/2016 09:06 PM, Reid Kleckner v

Re: r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

2016-03-22 Thread Stephan Bergmann via cfe-commits
On 03/17/2016 09:06 PM, Reid Kleckner via cfe-commits wrote: Author: rnk Date: Thu Mar 17 15:06:58 2016 New Revision: 263740 URL: http://llvm.org/viewvc/llvm-project?rev=263740&view=rev Log: Revert "For MS ABI, emit dllexport friend functions defined inline in class" This reverts commit r263738

r263740 - Revert "For MS ABI, emit dllexport friend functions defined inline in class"

2016-03-19 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Mar 17 15:06:58 2016 New Revision: 263740 URL: http://llvm.org/viewvc/llvm-project?rev=263740&view=rev Log: Revert "For MS ABI, emit dllexport friend functions defined inline in class" This reverts commit r263738. This appears to cause a failure in CXX/temp/temp.decls/temp.