Re: r260742 - [CMake] Improve the clang order-file generation workflow

2016-02-16 Thread ChrisBieneman via cfe-commits
Ugh... That is most scary. Do you happen to know if this occurred with Gold, GNU ld or both? I had tested this patch on Darwin, FreeBSD and Linux with GNU ld. For that error to happen it means that the linker isn't handling -order_file as an invalid argument instead it is treating it as a "-o" a

Re: r260742 - [CMake] Improve the clang order-file generation workflow

2016-02-16 Thread Chandler Carruth via cfe-commits
FYI, I had to revert this in r261054 because it caused Linux links to write the output to 'rder_file' in all cases. See that commit for some details, and I think several build bots hit this as well. Happy to chat to help figure out what to do long term. -Chandler On Fri, Feb 12, 2016 at 1:41 PM C

r260742 - [CMake] Improve the clang order-file generation workflow

2016-02-12 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Fri Feb 12 15:36:55 2016 New Revision: 260742 URL: http://llvm.org/viewvc/llvm-project?rev=260742&view=rev Log: [CMake] Improve the clang order-file generation workflow Summary: This commit re-lands r259862. The underlying cause of the build breakage was an incorrectly wr