Sorry for not following up here; this will actually be solved in an
entirely different way by http://reviews.llvm.org/D17183
On Thu, Mar 3, 2016 at 5:53 PM, Rafael Espíndola
wrote:
> As a first patch I think you can just leave every
>
> UserLabelPrefix = ""
>
> in place.
>
> Cheers,
> Rafael
___
As a first patch I think you can just leave every
UserLabelPrefix = ""
in place.
Cheers,
Rafael
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Yes, I understand this -- but the whole idea of my patch is to change
the blanket default, on the whole table.
Rafael believes this is the right thing to do (actually, he is the one
who requested the change), and judging by feedback on PR26255, he is
right.
Please let me know when you'll add the
Imagine there's a 2d table of values for UserLabelPrefix, each row for CPU
and column for OS. The value of many if those cells was changed by this
commit, because you stopped painting columns as "".
That is, originally, the default entry was "_", then cpu rows were filled,
and then the os columns
Hi James,
> I reverted this change with r258894, as it breaks (at least) sparc-rtems.
Can you send me a reproducer, please?
Right now I'm at a dead end -- no tests are broken, and no buildbots
are reported any fails. Yet you claim that my patch breaks one target
-- and there is zero info how to
I reverted this change with r258894, as it breaks (at least) sparc-rtems.
Clearly this area of the code was not sufficiently covered by the testsuite.
On Fri, Jan 22, 2016 at 10:24 AM, Andrey Bokhanko via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: asbokhan
> Date: Fri Jan 22 09:24
Author: asbokhan
Date: Fri Jan 22 09:24:34 2016
New Revision: 258504
URL: http://llvm.org/viewvc/llvm-project?rev=258504&view=rev
Log:
Change of UserLabelPrefix default value from "_" to ""
Differential Revision: http://reviews.llvm.org/D16295
Modified:
cfe/trunk/lib/Basic/TargetInfo.cpp
