Re: r253898 - Driver: fallback to the location of clang if no sysroot,

2015-11-24 Thread Martell Malone via cfe-commits
> > Searching for gcc on Linux is not a good idea, you'll find the system one > not the mingw one. Searching for i686-w64-mingw32-gcc or > x86_64-w64-mingw32-gcc should work better, that is searching for: > getTriple().getArchName()) + "-w64-mingw32-gcc" Moreover, this should work on Windows as

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

2015-11-24 Thread Yaron Keren via cfe-commits
Searching for gcc on Linux is not a good idea, you'll find the system one not the mingw one. Searching for i686-w64-mingw32-gcc or x86_64-w64-mingw32-gcc should work better, that is searching for: getTriple().getArchName()) + "-w64-mingw32-gcc" Moreover, this should work on Windows as well, min

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

2015-11-24 Thread Martell Malone via cfe-commits
> > Why not hardcode /usr for Linux hosts? Portable toolchain packages exist but can't on linux if you do this. but in general I'm sure most would agree that detection is much better then hard coding. This is why Yaron approved the patch Well this is a custom clang it can be anywhere. Official on

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

2015-11-24 Thread Ismail Donmez via cfe-commits
On Tue, Nov 24, 2015 at 12:43 PM, Martell Malone wrote: >> This breaks mingw support on openSUSE : > > My first question is why on SUSE is clang installed in /opt while mingw-w64 > in /usr? Well this is a custom clang it can be anywhere. Official one is in /usr. >> x86_64-w64-mingw32-gcc is in $

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

2015-11-24 Thread Martell Malone via cfe-commits
> > This breaks mingw support on openSUSE : My first question is why on SUSE is clang installed in /opt while mingw-w64 in /usr? x86_64-w64-mingw32-gcc is in $PATH, and this used to work fine before > this commit. It doesn't look for gcc on linux that is a windows host only thing. It didn't do t

Re: r253898 - Driver: fallback to the location of clang if no sysroot,

2015-11-24 Thread Ismail Donmez via cfe-commits
Hi, On Mon, Nov 23, 2015 at 8:59 PM, Martell Malone via cfe-commits wrote: > Author: martell > Date: Mon Nov 23 12:59:48 2015 > New Revision: 253898 > > URL: http://llvm.org/viewvc/llvm-project?rev=253898&view=rev > Log: > Driver: fallback to the location of clang if no sysroot, > > hard coding /

r253898 - Driver: fallback to the location of clang if no sysroot,

2015-11-23 Thread Martell Malone via cfe-commits
Author: martell Date: Mon Nov 23 12:59:48 2015 New Revision: 253898 URL: http://llvm.org/viewvc/llvm-project?rev=253898&view=rev Log: Driver: fallback to the location of clang if no sysroot, hard coding /usr makes little sense for mingw-w64. If we have portable toolchains having /usr breaks that.