Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

2015-11-16 Thread Sean Silva via cfe-commits
On Mon, Nov 16, 2015 at 7:09 PM, Richard Smith wrote: > On Mon, Nov 16, 2015 at 7:00 PM, Sean Silva wrote: > >> On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith >> wrote: >> >>> On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: >>> > >>> > >>> > >>> > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith vi

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

2015-11-16 Thread Richard Smith via cfe-commits
On Mon, Nov 16, 2015 at 7:00 PM, Sean Silva wrote: > On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith > wrote: > >> On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: >> > >> > >> > >> > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> >> >> A

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

2015-11-16 Thread Sean Silva via cfe-commits
On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith wrote: > On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: > > > > > > > > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > >> Author: rsmith > >> Date: Thu Nov 12 23:14:45 2015 > >> New Revisio

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

2015-11-14 Thread Richard Smith via cfe-commits
On Nov 13, 2015 7:23 PM, "Sean Silva" wrote: > > > > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: >> >> Author: rsmith >> Date: Thu Nov 12 23:14:45 2015 >> New Revision: 253012 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=253012&view=rev

Re: r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

2015-11-13 Thread Sean Silva via cfe-commits
On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Nov 12 23:14:45 2015 > New Revision: 253012 > > URL: http://llvm.org/viewvc/llvm-project?rev=253012&view=rev > Log: > [modules] When a declaration has non-trivial visibi

r253012 - [modules] When a declaration has non-trivial visibility, check whether it's

2015-11-12 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Nov 12 23:14:45 2015 New Revision: 253012 URL: http://llvm.org/viewvc/llvm-project?rev=253012&view=rev Log: [modules] When a declaration has non-trivial visibility, check whether it's actually hidden before we check its linkage. This avoids computing the linkage "too early