Re: r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

2015-11-02 Thread Nico Weber via cfe-commits
On Mon, Nov 2, 2015 at 3:00 PM, John McCall wrote: > On Nov 2, 2015, at 2:53 PM, Nico Weber wrote: > On Fri, Oct 30, 2015 at 5:55 PM, John McCall wrote: > >> > On Oct 30, 2015, at 5:39 PM, Nico Weber wrote: >> > Hi John, >> > >> > this breaks programs that use __weak and target 10.6, like so:

Re: r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

2015-11-02 Thread John McCall via cfe-commits
> On Nov 2, 2015, at 2:53 PM, Nico Weber wrote: > On Fri, Oct 30, 2015 at 5:55 PM, John McCall > wrote: > > On Oct 30, 2015, at 5:39 PM, Nico Weber > > wrote: > > Hi John, > > > > this breaks programs that use __weak and target 10.6, like so

Re: r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

2015-11-02 Thread Nico Weber via cfe-commits
On Fri, Oct 30, 2015 at 5:55 PM, John McCall wrote: > > On Oct 30, 2015, at 5:39 PM, Nico Weber wrote: > > Hi John, > > > > this breaks programs that use __weak and target 10.6, like so: > > > > $ cat test.m > > #import > > @interface I : NSObject { > > __weak NSObject* foo_; > > } > > - (NSO

Re: r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

2015-10-30 Thread John McCall via cfe-commits
> On Oct 30, 2015, at 5:39 PM, Nico Weber wrote: > Hi John, > > this breaks programs that use __weak and target 10.6, like so: > > $ cat test.m > #import > @interface I : NSObject { > __weak NSObject* foo_; > } > - (NSObject*)foo; > @end > > @implementation I > - (NSObject *)foo { > return

r251041 - Define weak and __weak to mean ARC-style weak references, even in MRC.

2015-10-22 Thread John McCall via cfe-commits
Author: rjmccall Date: Thu Oct 22 13:38:17 2015 New Revision: 251041 URL: http://llvm.org/viewvc/llvm-project?rev=251041&view=rev Log: Define weak and __weak to mean ARC-style weak references, even in MRC. Previously, __weak was silently accepted and ignored in MRC mode. That makes this a potenti