Re: r249995 - [Sema] Allow C conversions in C overload logic

2016-01-12 Thread George Burgess IV via cfe-commits
ISTM that there's no established way to tell Sema::Diag to not emit its diagnostic, and trying to swap to e.g. Sema::CanPerformCopyInitialization makes us too forgiving. So, given that we need to use CheckSingleAssignmentConstraints directly, I don't see a better way to handle this than plumbing th

Re: r249995 - [Sema] Allow C conversions in C overload logic

2016-01-12 Thread George Burgess IV via cfe-commits
Sorry for the delayed response; one of my filters silently marked this mail as read. Looking into it now. :) On Fri, Jan 8, 2016 at 12:38 PM, Bob Wilson wrote: > George, > > This change caused a serious regression for Objective-C method lookup. See > PR26085 (http://llvm.org/pr26085). > > For th

Re: r249995 - [Sema] Allow C conversions in C overload logic

2016-01-08 Thread Bob Wilson via cfe-commits
George, This change caused a serious regression for Objective-C method lookup. See PR26085 (http://llvm.org/pr26085). For the test case in that PR, Sema::SelectBestMethod looks at the two candidate "test" methods. It will match the second one, but in the process of considering the first candid

r249995 - [Sema] Allow C conversions in C overload logic

2015-10-11 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Sun Oct 11 15:13:20 2015 New Revision: 249995 URL: http://llvm.org/viewvc/llvm-project?rev=249995&view=rev Log: [Sema] Allow C conversions in C overload logic C allows for some implicit conversions that C++ does not, e.g. void* -> char*. This patch teaches clang that these conv