Re: r246610 - Migrate the target attribute parsing code into an extension off of

2015-09-02 Thread Eric Christopher via cfe-commits
And I think I've fixed the other bits in dzur:~/sources/llvm/tools/clang> git svn dcommit Committing to https://llvm.org/svn/llvm-project/cfe/trunk ... M include/clang/Basic/Attr.td M lib/CodeGen/CGCall.cpp Committed r246706 We could eventually cache the parsing etc, but I don't think it's hugely

Re: r246610 - Migrate the target attribute parsing code into an extension off of

2015-09-02 Thread Eric Christopher via cfe-commits
On Wed, Sep 2, 2015 at 10:11 AM Aaron Ballman wrote: > On Wed, Sep 2, 2015 at 1:07 PM, Eric Christopher > wrote: > > > > > > On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman > wrote: > >> > >> A few nits in addition to what Ben pointed out... > >> > >> On Tue, Sep 1, 2015 at 8:12 PM, Eric Christoph

Re: r246610 - Migrate the target attribute parsing code into an extension off of

2015-09-02 Thread Aaron Ballman via cfe-commits
On Wed, Sep 2, 2015 at 1:07 PM, Eric Christopher wrote: > > > On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman wrote: >> >> A few nits in addition to what Ben pointed out... >> >> On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits >> wrote: >> > Author: echristo >> > Date: Tue Sep 1 1

Re: r246610 - Migrate the target attribute parsing code into an extension off of

2015-09-02 Thread Eric Christopher via cfe-commits
On Wed, Sep 2, 2015 at 7:24 AM Aaron Ballman wrote: > A few nits in addition to what Ben pointed out... > > On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits > wrote: > > Author: echristo > > Date: Tue Sep 1 19:12:02 2015 > > New Revision: 246610 > > > > URL: http://llvm.org/view

Re: r246610 - Migrate the target attribute parsing code into an extension off of

2015-09-02 Thread Aaron Ballman via cfe-commits
A few nits in addition to what Ben pointed out... On Tue, Sep 1, 2015 at 8:12 PM, Eric Christopher via cfe-commits wrote: > Author: echristo > Date: Tue Sep 1 19:12:02 2015 > New Revision: 246610 > > URL: http://llvm.org/viewvc/llvm-project?rev=246610&view=rev > Log: > Migrate the target attribu

Re: r246610 - Migrate the target attribute parsing code into an extension off of

2015-09-02 Thread Benjamin Kramer via cfe-commits
> On 02.09.2015, at 02:12, Eric Christopher via cfe-commits > wrote: > > Author: echristo > Date: Tue Sep 1 19:12:02 2015 > New Revision: 246610 > > URL: http://llvm.org/viewvc/llvm-project?rev=246610&view=rev > Log: > Migrate the target attribute parsing code into an extension off of > the m

r246610 - Migrate the target attribute parsing code into an extension off of

2015-09-01 Thread Eric Christopher via cfe-commits
Author: echristo Date: Tue Sep 1 19:12:02 2015 New Revision: 246610 URL: http://llvm.org/viewvc/llvm-project?rev=246610&view=rev Log: Migrate the target attribute parsing code into an extension off of the main attribute and cache the results so we don't have to parse a single attribute more than