Re: r246468 - Pull the target attribute parsing out of CGCall and onto TargetInfo.

2015-08-31 Thread Eric Christopher via cfe-commits
On Mon, Aug 31, 2015 at 4:34 PM Richard Smith wrote: > On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: echristo >> Date: Mon Aug 31 13:39:22 2015 >> New Revision: 246468 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=24646

Re: r246468 - Pull the target attribute parsing out of CGCall and onto TargetInfo.

2015-08-31 Thread Richard Smith via cfe-commits
On Mon, Aug 31, 2015 at 11:39 AM, Eric Christopher via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: echristo > Date: Mon Aug 31 13:39:22 2015 > New Revision: 246468 > > URL: http://llvm.org/viewvc/llvm-project?rev=246468&view=rev > Log: > Pull the target attribute parsing out of CGCa

Re: r246468 - Pull the target attribute parsing out of CGCall and onto TargetInfo.

2015-08-31 Thread Eric Christopher via cfe-commits
Aha. This is what's causing Siva Chandra's problem. Hrm, I'll see what I can figure out. I'll revert until then or talk to Richard. -eric On Mon, Aug 31, 2015 at 4:02 PM Hans Wennborg wrote: > This change makes Basic depend on AST. > > The immediate problem I'm hitting is clang-format (which u

Re: r246468 - Pull the target attribute parsing out of CGCall and onto TargetInfo.

2015-08-31 Thread Hans Wennborg via cfe-commits
This change makes Basic depend on AST. The immediate problem I'm hitting is clang-format (which uses Basic but not AST) failing to link on Windows [1], but I suspect this could cause problems elsewhere too. Is there some way to avoid this dependency? [1]. http://build.chromium.org/p/chromium.f

r246468 - Pull the target attribute parsing out of CGCall and onto TargetInfo.

2015-08-31 Thread Eric Christopher via cfe-commits
Author: echristo Date: Mon Aug 31 13:39:22 2015 New Revision: 246468 URL: http://llvm.org/viewvc/llvm-project?rev=246468&view=rev Log: Pull the target attribute parsing out of CGCall and onto TargetInfo. Also: - Add a typedef to make working with the result easier. - Update callers to use the