Re: r246229 - [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX.

2015-09-09 Thread Eric Christopher via cfe-commits
On Mon, Aug 31, 2015 at 4:03 PM Ahmed Bougacha wrote: > On Thu, Aug 27, 2015 at 7:19 PM, Eric Christopher > wrote: > >> Hi Ahmed, >> >> A quick note: I think this is going to fail in the presence of the target >> attribute. I.e. if someone decorates a function with >> __attribute__((target("avx5

Re: r246229 - [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX.

2015-08-31 Thread Ahmed Bougacha via cfe-commits
On Thu, Aug 27, 2015 at 7:19 PM, Eric Christopher wrote: > Hi Ahmed, > > A quick note: I think this is going to fail in the presence of the target > attribute. I.e. if someone decorates a function with > __attribute__((target("avx512"))) this is unlikely to catch that. > You're right; any ideas

Re: r246229 - [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX.

2015-08-27 Thread Eric Christopher via cfe-commits
Hi Ahmed, A quick note: I think this is going to fail in the presence of the target attribute. I.e. if someone decorates a function with __attribute__((target("avx512"))) this is unlikely to catch that. Also, should we do this for all of the x86 OSes? -eric On Thu, Aug 27, 2015 at 3:31 PM Ahmed

r246229 - [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX.

2015-08-27 Thread Ahmed Bougacha via cfe-commits
Author: ab Date: Thu Aug 27 17:30:38 2015 New Revision: 246229 URL: http://llvm.org/viewvc/llvm-project?rev=246229&view=rev Log: [X86] Conditionalize Darwin MaxVectorAlign on the presence of AVX. There's no point in using a larger alignment if we have no instructions that would benefit from it.