Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-20 Thread Hans Wennborg via cfe-commits
I've reverted r245456 in r245623. Thanks, Hans On Thu, Aug 20, 2015 at 2:56 PM, Richard Smith wrote: > The cumulative effect of all the patches so far has been to revert this > change from trunk. Hans, can you revert it on the branch too? > > Thanks. > > On Wed, Aug 19, 2015 at 1:51 PM, Martell

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-20 Thread Richard Smith via cfe-commits
The cumulative effect of all the patches so far has been to revert this change from trunk. Hans, can you revert it on the branch too? Thanks. On Wed, Aug 19, 2015 at 1:51 PM, Martell Malone wrote: > Thanks for the spot yaron. > I had only tested x64 at the time as that's what the original bug r

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-19 Thread Martell Malone via cfe-commits
Thanks for the spot yaron. I had only tested x64 at the time as that's what the original bug report was for. I can confirm that your fix does infact fix i686 Many Thanks Martell On Wed, Aug 19, 2015 at 1:22 PM, Yaron Keren wrote: > Yes, worth merging with Richard approval. > > 2015-08-19 23:16

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-19 Thread Yaron Keren via cfe-commits
Yes, worth merging with Richard approval. 2015-08-19 23:16 GMT+03:00 Hans Wennborg : > I assume this is a merge request? > > Richard: what do you think about r245459+r245462? > > > > On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren > wrote: > > Sorry to notice late (just diagnosed the issue from a

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-19 Thread Hans Wennborg via cfe-commits
I assume this is a merge request? Richard: what do you think about r245459+r245462? On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren wrote: > Sorry to notice late (just diagnosed the issue from a failing boost::math > test), according to i686 ABI, long double size on x86 is 12 bytes (the > memory

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-19 Thread Yaron Keren via cfe-commits
Sorry to notice late (just diagnosed the issue from a failing boost::math test), according to i686 ABI, long double size on x86 is 12 bytes (the memory allocated, not the underlying 80 bits register), see https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html -m128bit-long-double

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-19 Thread Hans Wennborg via cfe-commits
On Tue, Aug 18, 2015 at 6:11 PM, Richard Smith wrote: > On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg wrote: >> >> Richard, I tried to ping you on the review thread but I'm not sure it >> got through. Martell requested this be merged to 3.7. What do you >> think? > > > LGTM Thanks! r245456. >

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-18 Thread Richard Smith via cfe-commits
On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg wrote: > Richard, I tried to ping you on the review thread but I'm not sure it > got through. Martell requested this be merged to 3.7. What do you > think? LGTM > On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits > wrote: > > Auth

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-18 Thread Hans Wennborg via cfe-commits
Richard, I tried to ping you on the review thread but I'm not sure it got through. Martell requested this be merged to 3.7. What do you think? On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits wrote: > Author: martell > Date: Fri Aug 14 14:05:56 2015 > New Revision: 245084 > > URL:

r245084 - WindowsX86: long double is x87DoubleExtended on mingw

2015-08-14 Thread Martell Malone via cfe-commits
Author: martell Date: Fri Aug 14 14:05:56 2015 New Revision: 245084 URL: http://llvm.org/viewvc/llvm-project?rev=245084&view=rev Log: WindowsX86: long double is x87DoubleExtended on mingw Summary: long double on x86 mingw is 80bits and is aligned to 16bytes Fixes: https://llv