Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

2015-11-15 Thread Yaron Keren via cfe-commits
r253161 2015-11-14 22:45 GMT+02:00 Martell Malone : > The reason why I didn't use -fuse-ld=lld2 was because on Windows we don't > have symlinks. > I figured passing flavor gets over this hurdle and the installation takes > up less space. > If you want to change it I have no objections we will jus

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

2015-11-14 Thread Martell Malone via cfe-commits
The reason why I didn't use -fuse-ld=lld2 was because on Windows we don't have symlinks. I figured passing flavor gets over this hurdle and the installation takes up less space. If you want to change it I have no objections we will just have to look at having lld's cmake to ensure it is created on

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

2015-11-14 Thread Yaron Keren via cfe-commits
Filipe: with mingw targetting Windows/COFF files I think only ld and lld makes sense as gold creates ELF files. I included Microsoft link.exe in the mingw-useld test but rethinking, no one really uses that configuration, see attached patch. Is that what you mean? Rafael: running under Windows whic

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

2015-11-14 Thread Rafael Espíndola via cfe-commits
On 15 November 2015 at 02:39, Filipe Cabecinhas wrote: > Handling of values other than lld looked weird. > Can you make it a hard error to use something other than, I guess, ld, gold, > lld? > Or are there other linkers available? What I find strange is that we use -flavor at all. We should ideal

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

2015-11-14 Thread Filipe Cabecinhas via cfe-commits
Handling of values other than lld looked weird. Can you make it a hard error to use something other than, I guess, ld, gold, lld? Or are there other linkers available? Filipe On Friday, 13 November 2015, Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Sure, r253066. > > > 20

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

2015-11-13 Thread Yaron Keren via cfe-commits
Sure, r253066. 2015-11-13 19:40 GMT+02:00 Rafael Espíndola : > This needs a testcase. Nothing is checking the linker invocation. > > On 14 July 2015 at 01:23, Yaron Keren wrote: > > Author: yrnkrn > > Date: Tue Jul 14 00:23:34 2015 > > New Revision: 242121 > > > > URL: http://llvm.org/viewvc/ll

Re: r242121 - Add support for -fuse-ld= in the mingw toolchain driver.

2015-11-13 Thread Rafael Espíndola via cfe-commits
This needs a testcase. Nothing is checking the linker invocation. On 14 July 2015 at 01:23, Yaron Keren wrote: > Author: yrnkrn > Date: Tue Jul 14 00:23:34 2015 > New Revision: 242121 > > URL: http://llvm.org/viewvc/llvm-project?rev=242121&view=rev > Log: > Add support for -fuse-ld= in the mingw