Re: r372679 - [static analyzer] Define __clang_analyzer__ macro in driver

2019-09-23 Thread Jan Korous via cfe-commits
Well, those were not fixups in the sense that I was aware of anything broken... Anyway, I don't see a quick fix for clang-tidy so I'm going to revert. > On Sep 23, 2019, at 8:00 PM, Nico Weber wrote: > > Even after all the fixup attempts, there's still a failing clang-tools-extra > test: > >

Re: r372679 - [static analyzer] Define __clang_analyzer__ macro in driver

2019-09-23 Thread Nico Weber via cfe-commits
Even after all the fixup attempts, there's still a failing clang-tools-extra test: ninja: Entering directory `out/gn' [0/2] ACTION //clang-tools-extra/test:check-clang-tools(//llvm/utils/gn/build/toolchain:unix) -- Testing: 787 tests, 64 threads -- Testing: 0 .. 10 FAIL: Clang Tools :: clang-tidy/