Re: r338455 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-08-03 Thread Richard Smith via cfe-commits
On Wed, 1 Aug 2018 at 10:52, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > We hit this in Chromium too, see crbug.com/869824 > > I've reverted in r338602 > Thanks, fixed and re-landed in r338941. > On Wed, Aug 1, 2018 at 5:26 PM, Benjamin Kramer via cfe-commits > wrote:

Re: r338455 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-08-01 Thread Hans Wennborg via cfe-commits
We hit this in Chromium too, see crbug.com/869824 I've reverted in r338602 On Wed, Aug 1, 2018 at 5:26 PM, Benjamin Kramer via cfe-commits wrote: > It's pretty easy to make this crash > > $ cat memcpy.c > void foo() { > int a[1], b; > memcpy((char*)a, (const char*)&b, (unsigned long)4); > }

Re: r338455 - [constexpr] Support for constant evaluation of __builtin_memcpy and

2018-08-01 Thread Benjamin Kramer via cfe-commits
It's pretty easy to make this crash $ cat memcpy.c void foo() { int a[1], b; memcpy((char*)a, (const char*)&b, (unsigned long)4); } $ clang memcpy.c llvm/include/llvm/ADT/SmallVector.h:178: const_reference llvm::SmallVectorTemplateCommon::back() const [T = clang::APValue::LValue PathEntry]: A