Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-30 Thread Pavel Labath via cfe-commits
I've managed to hack together an implementation of this proposal. I've put it up at so you have an idea of where I'm going with this. It seems to work fine (I've managed to bootstrap clang with it), though I'm not exactly proud of the implementation. Let me know w

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-30 Thread Pavel Labath via cfe-commits
Thank you for the explanation Chandler. This patch is not on a critical path for me, so I don't mind it taking a while (though it would be nice to fix as this is a also long standing cause of expression evaluation failures in LLDB). I believe that best solution here would be extend the set of cond

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-28 Thread Chandler Carruth via cfe-commits
On Sat, Jul 28, 2018 at 2:26 AM Chandler Carruth wrote: > On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: labath >> Date: Thu Jul 19 07:05:22 2018 >> New Revision: 337456 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=337456&vie

Re: r337456 - [CodeGen] Disable aggressive structor optimizations at -O0, take 3

2018-07-28 Thread Chandler Carruth via cfe-commits
On Thu, Jul 19, 2018 at 7:10 AM Pavel Labath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: labath > Date: Thu Jul 19 07:05:22 2018 > New Revision: 337456 > > URL: http://llvm.org/viewvc/llvm-project?rev=337456&view=rev > Log: > [CodeGen] Disable aggressive structor optimizations a