PTAL: https://reviews.llvm.org/D52647
On Fri, Sep 28, 2018 at 2:13 PM Eric Liu wrote:
> (Oops, forgot there was this thread. Pasting my response to r338255 here).
>
> > The code seemed obviously wrong there (calling accessibility checking,
> passing a possibly unrelated class) and the tests didn
(Oops, forgot there was this thread. Pasting my response to r338255 here).
> The code seemed obviously wrong there (calling accessibility checking,
passing a possibly unrelated class) and the tests didn't break after
reverting it.
It turns out that this was due to my lacking LIT test skill. LIT d
I actually tried to pass the correct derived scope to
CodeCompletionDeclConsumer on construction, it was not a lot of code and I
think this should fix the problem you're describing.
I'll send a patch.
On Tue, Jul 31, 2018 at 11:33 AM Eric Liu wrote:
> Thanks a lot for looking into this!
>
> You
Thanks a lot for looking into this!
You are right, the change in SemaAccess seemed to have done the job to fix
the protected member bug in specific. I think I made the change in
SemaCodeComplete before SemaAccess and didn't realized the previous one was
unnecessary to fix the tests. I think the ac
Prtially reverted the commit in r338255 to fix a very frequent crash.
The code seemed obviously wrong there (calling accessibility checking,
passing a possibly unrelated class) and the tests didn't break after
reverting it.
Let me know if I missed anything.
On Thu, Jul 19, 2018 at 3:37 PM Eric Li
