Re: r337152 - [Sema] Reword warning for constant captures that are not required

2018-07-17 Thread Benjamin Kramer via cfe-commits
Thanks for noticing. Reverted for now in r337278. The wording is still bad, but talking about ODR uses in there feels worse. On Tue, Jul 17, 2018 at 1:02 PM Malcolm Parsons wrote: > On Mon, 16 Jul 2018 at 10:57, Benjamin Kramer via cfe-commits > wrote: > > - auto explicit_by_value_unused_sizeo

Re: r337152 - [Sema] Reword warning for constant captures that are not required

2018-07-17 Thread Malcolm Parsons via cfe-commits
On Mon, 16 Jul 2018 at 10:57, Benjamin Kramer via cfe-commits wrote: > - auto explicit_by_value_unused_sizeof = [i] { return sizeof(i); }; // > expected-warning{{lambda capture 'i' is not required to be captured for this > use}} > + auto explicit_by_value_unused_sizeof = [i] { return sizeof(i)