Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

2018-06-26 Thread Teresa Johnson via cfe-commits
a Johnson > *Date: *Tuesday, June 26, 2018 at 4:11 PM > *To: *Shoaib Meenai > *Cc: *"cfe-commits@lists.llvm.org" > *Subject: *Re: r335618 - [ThinLTO] Add testing of summary index parsing > to a couple CFI tests > > > > I haven't seen any bot failures for the

Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

2018-06-26 Thread Shoaib Meenai via cfe-commits
Ah, my llvm-as was indeed out of date. I made check-clang depend on llvm-as in r335686 to avoid this issue in the future. From: Teresa Johnson Date: Tuesday, June 26, 2018 at 4:11 PM To: Shoaib Meenai Cc: "cfe-commits@lists.llvm.org" Subject: Re: r335618 - [ThinLTO] Add testing

Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

2018-06-26 Thread Teresa Johnson via cfe-commits
I haven't seen any bot failures for the change. The failing check was there before, so presumably llvm-dis on its own is producing the expected lines, just not when it goes through llvm-as. Can you let me know whether llvm-as has been updated and whether it gives an error. Note that there were a nu

Re: r335618 - [ThinLTO] Add testing of summary index parsing to a couple CFI tests

2018-06-26 Thread Shoaib Meenai via cfe-commits
The check lines added here are failing for me on CentOS 7. https://reviews.llvm.org/P8091 has the lit output and the actual output being produced by one of the added RUN lines. My llvm and clang repositories are in sync. Any idea what might be going on here? From: cfe-commits on behalf of Tere