Thanks for adding the regression test.
I'll wait for @erichkeane's work AttibuteList's linked list fix before
trying to re-commit.
Michael
2018-06-27 7:12 GMT-05:00 Nico Weber :
> Here's another regression that was introduced by the patch:
> https://bugs.llvm.org/show_bug.cgi?id=37935 I landed
Here's another regression that was introduced by the patch:
https://bugs.llvm.org/show_bug.cgi?id=37935 I landed a test for that in
r335725 (in case you're wondering why there's a new test failure when you
reland).
Thanks for working on this!
On Tue, Jun 26, 2018 at 9:03 AM Michael Kruse via cfe-
Thank you for your reproducer. I debugged it and found the issue.
ngettext is defined as follows.
extern char *ngettext (const char *__msgid1, const char *__msgid2,
unsigned long int __n)
throw () __attribute__ ((__format_arg__ (1))) __attribute__
((__format_arg__ (2)));
Indeed, two
(Sorry for the late reply...)
On Mon, Jun 25, 2018 at 2:45 PM Michael Kruse via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I just revert if to have further discussions (r335516)
>
> Michael
>
> 2018-06-25 14:58 GMT-05:00 Eric Christopher :
> >
> >
> > On Mon, Jun 25, 2018 at 12:21 PM Rich
I just revert if to have further discussions (r335516)
Michael
2018-06-25 14:58 GMT-05:00 Eric Christopher :
>
>
> On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits
> wrote:
>>
>> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits
>> wrote:
>>>
>>> Hi,
>>>
>>> multiple comment
2018-06-25 14:20 GMT-05:00 Richard Smith :
> (I'm not sure what the problem is, but as a data point, Sema::checkCall
> iterates over the FormatAttrs in order, so it's possible that changing the
> order may have triggered a new warning. That may be due to a pre-existing
> order-dependence bug, or it
On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi,
>>
>> multiple comments in the code indicate that the attribute order was
>> surprising and
On 23 June 2018 at 22:34, Michael Kruse via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> multiple comments in the code indicate that the attribute order was
> surprising and probably has lead to bugs, and will lead to bugs in the
> future. The order had to be explicitly reversed to a
Hi,
multiple comments in the code indicate that the attribute order was
surprising and probably has lead to bugs, and will lead to bugs in the
future. The order had to be explicitly reversed to avoid those. This
alone for me this seems a good reason to have the attributes in the
order in which the
