Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

2017-08-28 Thread David Blaikie via cfe-commits
On Mon, Aug 28, 2017 at 5:21 PM Reid Kleckner wrote: > On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote: > >> Feels like this alignment attribute may be a bit of a death trap, then? >> Should other uses of the attribute be scrutinized, or could we come up with >> a portable way to use it saf

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

2017-08-28 Thread Reid Kleckner via cfe-commits
On Mon, Aug 28, 2017 at 5:02 PM, David Blaikie wrote: > Feels like this alignment attribute may be a bit of a death trap, then? > Should other uses of the attribute be scrutinized, or could we come up with > a portable way to use it safely? (using a different attribute on different > compilers -

Re: r310905 - Avoid PointerIntPair of constexpr EvalInfo structs

2017-08-28 Thread David Blaikie via cfe-commits
Feels like this alignment attribute may be a bit of a death trap, then? Should other uses of the attribute be scrutinized, or could we come up with a portable way to use it safely? (using a different attribute on different compilers - sounded like maybe one form worked with MSVC and a different for