Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

2017-08-11 Thread Bruno Cardoso Lopes via cfe-commits
On Fri, Aug 11, 2017 at 9:27 PM, Richard Smith wrote: > On 11 August 2017 at 16:51, Bruno Cardoso Lopes via cfe-commits > wrote: >> >> On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith >> wrote: >> > On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits >> > wrote: >> >> >> >> Sounds good to m

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

2017-08-11 Thread Richard Smith via cfe-commits
On 11 August 2017 at 16:51, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith > wrote: > > On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits > > wrote: > >> > >> Sounds good to me. > >> > >> Richard, what do you thin

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

2017-08-11 Thread Bruno Cardoso Lopes via cfe-commits
On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith wrote: > On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits > wrote: >> >> Sounds good to me. >> >> Richard, what do you think? >> >> On Thu, Aug 10, 2017 at 9:38 AM, Bruno Cardoso Lopes >> wrote: >> > Hi Hans, can we please get this merged i

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

2017-08-10 Thread Richard Smith via cfe-commits
On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Sounds good to me. > > Richard, what do you think? > > On Thu, Aug 10, 2017 at 9:38 AM, Bruno Cardoso Lopes > wrote: > > Hi Hans, can we please get this merged into 5.0? > > > > Thanks, > > > > On Thu

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

2017-08-10 Thread Hans Wennborg via cfe-commits
Sounds good to me. Richard, what do you think? On Thu, Aug 10, 2017 at 9:38 AM, Bruno Cardoso Lopes wrote: > Hi Hans, can we please get this merged into 5.0? > > Thanks, > > On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits > wrote: >> Author: bruno >> Date: Thu Aug 10 08:16

Re: r310605 - [Modules] Prevent #import to reenter header if not building a module.

2017-08-10 Thread Bruno Cardoso Lopes via cfe-commits
Hi Hans, can we please get this merged into 5.0? Thanks, On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Thu Aug 10 08:16:24 2017 > New Revision: 310605 > > URL: http://llvm.org/viewvc/llvm-project?rev=310605&view=rev > Log: > [Modules] Preven