Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-31 Thread Samuel Benzaquen via cfe-commits
On Thu, Mar 31, 2016 at 11:16 AM, David Blaikie wrote: > Yep, reproduces even with a plain (non template arg) function pointer - > and immediately goes away with a real function of the same type. > Thanks for the extra reduction. > That's bothersome. I played around with a few ways of writing

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-31 Thread David Blaikie via cfe-commits
Yep, reproduces even with a plain (non template arg) function pointer - and immediately goes away with a real function of the same type. That's bothersome. I played around with a few ways of writing the call-to-function-pointer but couldn't find any particular syntax that seemed to untickle GCC's

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-31 Thread Samuel Benzaquen via cfe-commits
I was able to reduce the bug to this: struct A { A(int (&)[1]); }; template int E() { int X[] = {0}; return F(X); } Note that the array is not empty and we are not using variadics anymore. The problem seems to be related to the function pointer template parameter. gcc doesn't want

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-28 Thread Samuel Benzaquen via cfe-commits
On Fri, Mar 25, 2016 at 7:01 PM, Richard Smith wrote: > On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits > wrote: > > > > > > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits > > wrote: > >> > >> Author: sbenza > >> Date: Fri Mar 25 12:46:02 2016 > >> New Revisi

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-25 Thread David Blaikie via cfe-commits
On Fri, Mar 25, 2016 at 4:01 PM, Richard Smith wrote: > On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits > wrote: > > > > > > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits > > wrote: > >> > >> Author: sbenza > >> Date: Fri Mar 25 12:46:02 2016 > >> New Revisi

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-25 Thread Richard Smith via cfe-commits
On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits wrote: > > > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits > wrote: >> >> Author: sbenza >> Date: Fri Mar 25 12:46:02 2016 >> New Revision: 264428 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=264428&view=re

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-25 Thread Alexey Samsonov via cfe-commits
On Fri, Mar 25, 2016 at 10:55 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: sbenza >> Date: Fri Mar 25 12:46:02 2016 >> New Revision: 264428 >> >> U

Re: r264428 - [ASTMatchers] Fix build for VariadicFunction.

2016-03-25 Thread David Blaikie via cfe-commits
On Fri, Mar 25, 2016 at 10:46 AM, Samuel Benzaquen via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: sbenza > Date: Fri Mar 25 12:46:02 2016 > New Revision: 264428 > > URL: http://llvm.org/viewvc/llvm-project?rev=264428&view=rev > Log: > [ASTMatchers] Fix build for VariadicFunction. >