Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

2016-03-28 Thread Daniel Jasper via cfe-commits
Hi Jean-Philippe, I have also been thinking some more about the naming and I think it is not entirely inaccurate. It is a setting of the option AlignAfterOpenBracket and setting that to "AlwaysBreak" means "always break instead of aligning". And it kind of makes sense that one-parameter functions

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

2016-03-28 Thread Jean-philippe Dufraigne via cfe-commits
Hi Daniel, Thanks, I understand why your users would have requested that and why you need to provide this improvement for them. I will survey the other people writing code with me on whether they are happy with this improvement considering both the readability of the statements and the relatively

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

2016-03-28 Thread Daniel Jasper via cfe-commits
Hi Jean-Philippe, no, you have not convinced me with those examples. There is not a single one, I find more readable. Many of them I find equally unreadable and would write the code differently. But I would never have chose AlwaysBreak for my own code in the first place and I rarely work in a code

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

2016-03-27 Thread Jean-philippe Dufraigne via cfe-commits
Hi Daniel, Thanks a lot for your answer and clarifications. Sorry for the long answer, TLDR at the beginning (and end for code examples). To answer your 2 questions immediately: - It happens a lot more than I thought, about 10% of the few thousands file I checked had instances of this. - Yes, the

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

2016-03-24 Thread Daniel Jasper via cfe-commits
Hi Jean-Philippe, first off, sorry that this is causing you trouble. I am always happy to reconsider. However, I do think that this is a good change based on hundreds of examples I have looked at. Obviously, this is subjective and I won't even start to make an argument on whether this is wasted o

Re: r263709 - clang-format: Slightly weaken AlignAfterOpenBracket=AlwaysBreak.

2016-03-20 Thread Jean-philippe Dufraigne via cfe-commits
Hi Daniel, I'm not sure I understand the logic behind modifying 'AlwaysBreak' to be 'AlwaysBreakExceptForSingleArgument'. AlwaysBreak is always going to lead to "wasted space". Some consider consistently break to not be a waste but actually contribute to readability, it seems that was what 'Alway