Re: r261767 - Add whole-program vtable optimization feature to Clang.

2016-02-25 Thread Steven Wu via cfe-commits
Thanks a lot! Steven > On Feb 25, 2016, at 7:12 PM, Peter Collingbourne wrote: > > (I don't understand why this flag needs to exist, but) I've implemented a > fix in r261960. > > Peter > > On Thu, Feb 25, 2016 at 06:50:52PM -0800, Steven Wu wrote: >> Hi Peter >> >> I notice after this comm

Re: r261767 - Add whole-program vtable optimization feature to Clang.

2016-02-25 Thread Peter Collingbourne via cfe-commits
(I don't understand why this flag needs to exist, but) I've implemented a fix in r261960. Peter On Thu, Feb 25, 2016 at 06:50:52PM -0800, Steven Wu wrote: > Hi Peter > > I notice after this commit, I can no longer use cmake option > -DCLANG_TOOL_DRIVER_BUILD=OFF to choose not to build and link

Re: r261767 - Add whole-program vtable optimization feature to Clang.

2016-02-25 Thread Steven Wu via cfe-commits
Hi Peter I notice after this commit, I can no longer use cmake option -DCLANG_TOOL_DRIVER_BUILD=OFF to choose not to build and link the clang driver. When using -DCLANG_TOOL_DRIVER_BUILD=OFF, clang target will not exist so cmake will error on the line: > +add_dependencies(clang vtables_blacklis