Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-26 Thread Reid Kleckner via cfe-commits
On Tue, Jan 26, 2016 at 4:36 AM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Is this really a good idea? Yes, there are many broken configure > scripts, but at the same point, this change makes it more difficult > to detect whether an option is supported. > Of cours

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-26 Thread Ehsan Akhgari via cfe-commits
Hi Renato, Thanks, Nico helped me diagnose and fix the test yesterday < http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160125/147979.html>. I fixed the test accordingly in r258776 and that seems to have worked! Cheers, Ehsan On Tue, Jan 26, 2016 at 7:41 AM, Renato Golin wrote: > Hi,

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-26 Thread Joerg Sonnenberger via cfe-commits
On Mon, Jan 25, 2016 at 09:14:52PM -, Ehsan Akhgari via cfe-commits wrote: > Author: ehsan > Date: Mon Jan 25 15:14:52 2016 > New Revision: 258720 > > URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev > Log: > [MSVC Compat] Only warn for unknown clang-cl arguments > > Summary: > MS

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-26 Thread Renato Golin via cfe-commits
On 26 January 2016 at 01:56, Ehsan Akhgari wrote: > OK, I reverted the test in r258772. Thanks! Ok, the error code with no output will make for an interesting investigation... :) I'll try to collect as much info as possible. In the meantime, if you have any insights, just let me know. cheers,

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Ehsan Akhgari via cfe-commits
OK, I reverted the test in r258772. Looking at the log, it's really not clear to me what's going on. I'd appreciate your help figuring this out. :-) On Mon, Jan 25, 2016 at 8:09 PM, Ehsan Akhgari wrote: > Ouch, sorry about that! I'm afk right now, I would appreciate if you can > revert it for

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Ehsan Akhgari via cfe-commits
Ouch, sorry about that! I'm afk right now, I would appreciate if you can revert it for me. I will look at fixing this tomorrow. On Jan 25, 2016 6:49 PM, "Renato Golin" wrote: > On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits > wrote: > > Author: ehsan > > Date: Mon Jan 25 15:14:52 201

Re: r258720 - [MSVC Compat] Only warn for unknown clang-cl arguments

2016-01-25 Thread Renato Golin via cfe-commits
On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits wrote: > Author: ehsan > Date: Mon Jan 25 15:14:52 2016 > New Revision: 258720 > > URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev > Log: > [MSVC Compat] Only warn for unknown clang-cl arguments Hi Eshan, Not sure you've see